search

Ikabot-Collective / ikabot

A Python-based bot designed for automating tasks in the game Ikariam
https://discord.com/invite/3hyxPRj
MIT License
103 stars 67 forks source link

Language sending freights #10

Closed 9Mad-Max5 closed 5 years ago

9Mad-Max5 commented 5 years ago

Hi, Just discoverd your program and I am amazed.

But the language in (2) send resources have some issues. It´s spanish instead of english.

As well I could help to translate it to german.

physics-sec commented 5 years ago

Im so glad you liked it!

I will definitely look into that

If you have the time and energy, i would love to support german, im actually learning it so it would be awesome! No pressure though

9Mad-Max5 commented 5 years ago

Hi,

yeah for sure no problem.

But in need a little help to find the wright spot to add the language.

An awesome feature would be to spread other ressources like wine.

So I need most of the time a lot of marble so i could just spread it like wine.

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Dienstag, 4. Juni 2019 01:46 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Im so glad you liked it!

I will definitely look into that

If you have the time and energy, i would love to support german, im actually learning it so it would be awesome! No pressure though

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY55GMSADKAGX5DRFODPYWULFA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW27ZNY#issuecomment-498465975 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY46GGGOS6VRM5XQ2XDPYWULFANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCYYMOECZYNZYJIPHZZDPYWULFA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW27ZNY.gif

physics-sec commented 5 years ago

Now that I think about it, I will have to make changes to the program because you would have to translate from spanish to german, which is of course less than ideal, it should be from english. I will change that later

Implement your suggestion should be easy, if i have the time I will try to implement it this weekend.

The translation issue should be fixed! update ikabot and check for yourself.

9Mad-Max5 commented 5 years ago

Hi,

I just updated the ikabot and seems to be fine working on my pi.

Maybe I have got some new ideas for the bot.

-A way to restart it with an standard restart script.

-The possibility to go back to a already used account would be great

That’s all at the moment.

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Dienstag, 4. Juni 2019 02:36 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Now that I think about it, I will have to make changes to the program because you would have to translate from spanish to german, which is of course less than ideal, it should be from english. I will change that later

Implement your suggestion should be easy, if i have the time I will try to implement it this weekend.

The translation issue should be fixed! update ikabot and check for yourself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY24CTZJYA5XKNDKAKDPYW2FRA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3CAVY#issuecomment-498475095 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY2A2BI7CIEPTNH43DTPYW2FRANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCY63MYB7EYABLLYPXB3PYW2FRA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3CAVY.gif

physics-sec commented 5 years ago

Well im totally open to new ideas, if you have some, let me know.

My computer broke today, so I won't be very active these days, until i fix it.

9Mad-Max5 commented 5 years ago

For sure i will let you know.

Puh that’s a real bummer.

Sad to hear you computer broke.

Do you already know what needs to be fixed?

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Mittwoch, 5. Juni 2019 01:43 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Well im totally open to new ideas, if you have some, let me know.

My computer broke today, so I won't be very active these days, until i fix it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY4K6WVY6QHTCRLGTA3PY34XFA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6FWPY#issuecomment-498883391 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY4Y2UEJXFPBNXINMYTPY34XFANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCYZJN4EQCXKZVRO7B2DPY34XFA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6FWPY.gif

physics-sec commented 5 years ago

yeah, a windows update broke my beloved dual boot with linux, I will have to reinstall it and probably lose some worthless files Anyway, let me know if you have any comments and I hope you enjoy ikabot :)

9Mad-Max5 commented 5 years ago

Hi,

i hope you could fixed your dual boot.

Till yesterday ikabot just ran on a pi 1 b.

And especially the sending goods section was poorly slow.

Because I didn´t have an computer running linux I installed the ubuntu terminal from win 10 to see if it is an performance issue.

On this pc it ran a little bit faster but still pretty poor.

Maybe after source and destination you could directly ask for the kind of goods.

Most of the time you just send Marble or something like this from one town to the other.

This could enhance the working speed.

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Donnerstag, 6. Juni 2019 03:19 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

yeah, a windows update broke my beloved dual boot with linux, I will have to reinstall it and probably lose some worthless files Anyway, let me know if you have any comments and I hope you enjoy ikabot :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY7NQPD6N7SLWVIEVULPZBQZRA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBORLY#issuecomment-499312815 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY6RNLPFVKTCUMAZ24LPZBQZRANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCY7PIGFWYYTRJLEMHF3PZBQZRA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBORLY.gif

physics-sec commented 5 years ago

the speed of ikabot relies highly on your internet connection,

but i will check if i can make things in a better way on that section, although i don't make any promises of great improvements.

did ikabot run on the ubuntu terminal from win 10?? i never tried it, i am very curious about that

physics-sec commented 5 years ago

well i actually found a way to make it faster, let me know if you notice the difference.

I will keep looking for other ways to improve it.

physics-sec commented 5 years ago

Well i found another way to improve the performance, i am quite happy it runs now

Update to version 4.3.9 and let me know!

9Mad-Max5 commented 5 years ago

Puh yeah now we are talking its just blazing fast.

Actually you can install on windows 10 an full Linux terminal.

With this it is possible to run ikabot without setting up a whole Virtual box.

https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/ https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/

it would be still nice to setup some accounts with credentials and not enter every time the whole username an tree for the account.

As well instead of a print with the code for the update entering it directly from the bot would work even better.

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Montag, 10. Juni 2019 22:09 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Well i found another way to improve the performance, i am quite happy it runs now

Update to version 4.3.9 and let me know!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY3AZYPOHL4TC524GR3PZ2YHJA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLCYPQ#issuecomment-500575294 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY5CTZ7EAIIPOEHZUBDPZ2YHJANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCY2DENODUY5AMXNHYATPZ2YHJA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLCYPQ.gif

physics-sec commented 5 years ago

Yeah I get it can be annoying to input the server, the world and the user every time, but it can be tricky to improve that if you use many accounts (as i do). Plus, the security of the users is my primary concern and making log in easier can be dangerous in some cases.

The update functionality used to actually run the command, but then i changed it because the user doesn't necessarily have root permissions, and if the the user calling ikabot isn't root, it will fail.

9Mad-Max5 commented 5 years ago

OK but i think if somebody can log in to the computer and open the terminal with ikabot he is already the owner.

Even if he isn´t he can´t make an deconstructive moves unless sending wine away.

On how much accounts do we talk on your site?

But should the command with sudo not run on any user if he is root or not`?

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Dienstag, 11. Juni 2019 02:28 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Yeah I get it can be annoying to input the server, the world and the user every time, but it can be tricky to improve that if you use many accounts (as i do). Plus, the security of the users is my primary concern and making log in easier can be dangerous in some cases.

The update functionality used to actually run the command, but then i changed it because the user doesn't necessarily have root permissions, and if the the user calling ikabot isn't root, it will fail.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY2LPKZZLD7NKCTLHQ3PZ3WRNA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLSXHY#issuecomment-500640671 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY524IFNCCFGJ4PL2ETPZ3WRNANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCY45UXF62R2XI44IKA3PZ3WRNA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLSXHY.gif

physics-sec commented 5 years ago

Well, a machine can have many users (including a root user) and that is why the cookies (which you can use to actually log in into the account) are encrypted with the password of the account.

That means that not even the root user can access to your ikabot or your ikariam account, and I wouldn't trade that for usability.

If a normal user (not root) runs ikabot and then ikabot runs the sudo "update" command, that will fail because a process can't run sudo. So I prefer to give the user the "copy and paste this command" message that will always work (assuming the user has root privileges). I know is not pretty but the alternative won't work for most users.

9Mad-Max5 commented 5 years ago

Ah ok.

Do you have telegram?

Maybe installing a shell script would help there?

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Dienstag, 11. Juni 2019 16:27 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Well, a machine can have many users (including a root user) and that is why the cookies (which you can use to actually log in into the account) are encrypted with the password of the account.

That means that not even the root user can access to your ikabot or your ikariam account, and I wouldn't trade that for usability.

If a normal user (not root) runs ikabot and then ikabot runs the sudo "update" command, that will fail because a process can't run sudo. So I prefer to give the user the "copy and paste this command" message that will always work (assuming the user has root privileges). I know is not pretty but the alternative won't work for most users.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCYYVGFYMZWMFTWOBNJLPZ6Y4RA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNJ4CQ#issuecomment-500866570 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCY42FMAPFFZJKLGARKDPZ6Y4RANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCY2D4RP2S5IQSUW5273PZ6Y4RA5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNJ4CQ.gif

physics-sec commented 5 years ago

I once tried thought about implementing some functionality with the pirates but I don't think is possible because ikariam makes you prove that you are not a robot by showing the user some images. A python script like ikabot can't resolve that.

And the error you got is because the ikabot process got a SIGHUP signal. Did you get it when you close the terminal? That shouldn't happen... may be the linux terminal of windows doesn't work exactly like linux. (You should be able to close the terminal)

physics-sec commented 5 years ago

I deleted your last comment so your ikariam username isn't visible, just in case...

9Mad-Max5 commented 5 years ago

Ah ok,

Correct from time to time there is an captcha.

But not every time so you could bring an error when a captcha is needed.

At the moment I got this hangup message it was running on an 24/7 running pi.

Ah ok thanks didn´t hought that far.

But I think you can´t do anything bad with just the username

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Mittwoch, 12. Juni 2019 16:47 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

I once tried thought about implementing some functionality with the pirates but I don't think is possible because ikariam makes you prove that you are not a robot by showing the user some images. A python script like ikabot can't resolve that.

And the error you got is because the ikabot process got a https://en.wikipedia.org/wiki/SIGHUP SIGHUP signal. Did you get it when you close the terminal? That shouldn't happen... may be the linux terminal of windows doesn't work exactly like linux. (You should be able to close the terminal)

— You are receiving this because you authored the thread. Reply to this email directly, https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY4YIVHXEBC4SWHVSYLP2ED67A5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQVQMA#issuecomment-501307440 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AG7HCYZDWGZB2M5F3NKHFY3P2ED67ANCNFSM4HSSOUCA mute the thread. https://github.com/notifications/beacon/AG7HCY35GLILCDQEBT5RRS3P2ED67A5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQVQMA.gif

physics-sec commented 5 years ago

Ok, update to version 4.3.10 and ikabot should ignore the SIGHUP signals, let me know if it crashes again please.

Nobody is going to do anything with the user but i prefer to be sure.

9Mad-Max5 commented 5 years ago

Uff.

Great you made a lot of nice changes.

Mit freundlichen Grüßen

Maximilian Hübner

Von: Physics notifications@github.com Gesendet: Donnerstag, 13. Juni 2019 03:45 An: physics-sp/ikabot ikabot@noreply.github.com Cc: 9Mad-Max5 maximilian.huebner95@gmx.de; Author author@noreply.github.com Betreff: Re: [physics-sp/ikabot] Language sending freights (#10)

Ok, update to version 4.3.10 and ikabot should ignore the SIGHUP signals, let me know if it crashes again please.

Nobody is going to do anything with the user but i prefer to be sure.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/physics-sp/ikabot/issues/10?email_source=notifications&email_token=AG7HCY33TMLT6L52KPF5VITP2GRB3A5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSIRUA#issuecomment-501516496 , or mute the thread https://github.com/notifications/unsubscribe-auth/AG7HCYYQARZAM4BQ44QMHHLP2GRB3ANCNFSM4HSSOUCA . https://github.com/notifications/beacon/AG7HCY62TW6NH2TJCASHI23P2GRB3A5CNFSM4HSSOUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSIRUA.gif