search

Ikabot-Collective / ikabot

A Python-based bot designed for automating tasks in the game Ikariam
https://discord.com/invite/3hyxPRj
MIT License
102 stars 67 forks source link

Versioning Issue during ikabot Deployment due to Reusable Workflows #270

Closed ElieTaillard closed 5 months ago

ElieTaillard commented 5 months ago

Bug explanation

Description:

When deploying new versions of ikabot, an automatic commit is made in the pipeline to increment the version. However, this commit is not included in the Docker image build. This issue seems to also occur with other release methods of ikabot, such as the .exe and pip package. As a result, there is a mismatch between the version shown in the program and the version indicated in the GitHub releases.

I suspect this issue might be related to the reusable workflows in our CI/CD pipeline.

Steps to Reproduce the Issue:

  1. Deploy a new version of ikabot.
  2. Compare the version in the program with the one indicated in the GitHub releases.

Expected Result: The version in the program should match the version indicated in the GitHub releases.

Observed Result: There is a mismatch between the version in the program and the version indicated in the GitHub releases. image image

Possible Solution: Investigate and ensure that the automatic versioning commit is correctly included in the Docker image build and other release methods (.exe, pip package) within the reusable workflows, before publishing the release on GitHub.

Additional Comments: This issue can cause confusion for users and complicate version tracking. A quick fix would be appreciated. Detailed investigation of the reusable workflows in the CI/CD pipeline might be necessary to identify the root cause.

Operating System

Win11

Ikabot installation

I'm using Docker

Ikabot version

v7.0.4

Python version

No response

ElieTaillard commented 5 months ago

I made a commit 17301097eadf41421bbc08a1ca8a739884b3f960 as a potential fix. Currently, it seems to correct the problem. For the next versions, we need to verify that this fix indeed resolves the issue.