Issue #38 fix - Githubissues

Ikcelaks / qmk_sequence_transform

Sequence-Transform is a user library for QMK that enables a rich declarative ruleset for transforming a sequence of keypresses into any output you would like.

Apache License 2.0

6 stars 3 forks source link

Issue #38 fix #42

Closed QKekos closed 8 months ago

QKekos commented 8 months ago

Issue #38 fix

QKekos commented 8 months ago

I cant figure how to actually stop compiling, before it was just a print, but somehow it stopped make with *** multiple target patterns. Stop., now it actually throws an error, but make keeps going - there is literally no place in the code which has multiple target patterns as a string to type it, where does it come from?

Do note that file doesnt get re-generated now, so it compiles with the last valid dictionary + prints all the duplicated lines
While main branch does regenerate the data, but doesnt let C compile to the actual binary, I think pr approach is better

Ikcelaks commented 8 months ago

multiple target patterns is a message from make. We need to have the QMK make process handle the output of the generator. I don't know make, so hopefully @kamih has ideas.

kamih commented 8 months ago

Instead of calling the script at the top of your layout's rules.mk, add this at the bottom:

all: st_build

st_build:
    python3 keyboards/moonlander/keymaps/kamih/sequence_transform/generator/sequence_transform_data.py

This adds a st_build dependency to the all build target. Python's raise SystemExit call will make it return 1. Any makefile command that doesn't return 0 fails that target, so this will make it fail the rule and compilation will not proceed.