search

IkechukwuAKalu / membrane_rtp_hls

RTP to HLS implementation using the Membrane Framework
Apache License 2.0
1 stars 0 forks source link

For some reason, when I run the pipeline, no file is saved in "output" folder #1

Open mariembenslama opened 2 years ago

mariembenslama commented 2 years ago

Exactly the title of the issue.

IkechukwuAKalu commented 2 years ago

Thanks for reporting this @mariembenslama. I'll try to reproduce this as soon as I can and give feedback.

IkechukwuAKalu commented 2 years ago

@mariembenslama please share all the commands/code you ran?

mariembenslama commented 2 years ago

@IkechukwuAKalu thanks for the response, actually for my case, whenever I add

https://github.com/IkechukwuAKalu/membrane_rtp_hls/blob/master/lib/membrane_rtp_hls/pipeline.ex#L64-L71

To any pipeline, it won't save anything, Though when I change this part to sink: %Membrane.File.Sink{location: ...}, it will work properly 🤔

I felt something is off whenever I add Membrane.HTTPAdaptiveStream.Sink

IkechukwuAKalu commented 2 years ago

@mariembenslama I'm glad that it works properly for you now. I guess something may have changed in the membrane framework

mariembenslama commented 2 years ago

Actually %Membrane.HTTPAdaptiveStream.Sink is still not working, I will need it when I integrate gcs instead of local storage, any idea how to fix that? 🤔 is it working for you? (I'm using membrane_core 10)

IkechukwuAKalu commented 2 years ago

Oh, that could be the difference because I just tested it today and it works fine; I'm using membrane_core 0.6.1. It has been a while I updated this project - I guess I should soon.

mariembenslama commented 2 years ago

I see, thanks for the answer, yeah I think sthg was missing in old and new version 👍🏻 (hopefully it gets fixed soon, I need this in new project Im working on).