Ikshi / assignment

0 stars 0 forks source link

test - Validates data received on Target hosts #10

Open dlapin-cribl opened 1 month ago

dlapin-cribl commented 1 month ago

Right now the test generates this generic error

     AssertionError: expected false to equal true
      + expected - actual

      -false
      +true

Even if events-target_1.log and events-target_2.log are empty the error would be the same. How would you modify your original implementation to include more useful information on what actually is wrong with received events?

Ikshi commented 1 month ago

@dlapin-cribl I would firstly check and retrieve the missing or invalid events when comparing the files then add the invalid events in the assertion so that when it fails it will log the invalid event. Also, another option is to compare the event log files separately with the original one and then assert on each event. For example, the original file and events-target_1.log should include event A.