Ilhasoft / RCApps.RapidPro-Channel

0 stars 1 forks source link

Possible typescript version conflict with @types/chai #7

Open rowanseymour opened 3 years ago

rowanseymour commented 3 years ago

I can't get rc-apps to deploy this with the given version of typescript and @types/chai: Out of the box I get:

   Starting App Deployment to Server

   Getting Server Info... ✓
   Packaging the app... ✖
 ›   Error:    ⟿  Error /Users/rowan/Nyaruka/RCApps.RapidPro-Channel/node_modules/@types/chai/index.d.ts (124,9): JSDoc types can only be used inside documentation
 ›   comments.

But it works if I bump typescript to 3.x

rowanseymour commented 3 years ago

I reported same issue on rc-apps at https://github.com/RocketChat/Rocket.Chat.Apps-cli/issues/97

Next problem I have is that I can't get rc-apps package to create something I can upload. It creates a zip with all typescript files compiled to javascript, but classFile in app.json has to be a typescript file. When I tried to upload it complains it can't find RapidProApp.ts. I don't know if that's related to bumping the version of typescript.

paulobernardoaf commented 3 years ago

What's the Rocket.Chat version that you are trying to upload the App's zip? After the typescript update from #10, I've ran rc-apps package and uploaded from the App's page at admin/apps route and it went well. Also the rc-apps deploy went fine too 😕.

rowanseymour commented 3 years ago

There's a PR for rc-apps to bump all the versions in the default template so maybe worth bumping others https://github.com/RocketChat/Rocket.Chat.Apps-cli/pull/95

I created an issue there for the package problem as well https://github.com/RocketChat/Rocket.Chat.Apps-cli/issues/98

I just created a trial Rocket.Chat account at https://rocket.chat for testing and it came like this...

Captura de Pantalla 2020-11-04 a la(s) 15 21 13
paulobernardoaf commented 3 years ago

Try running the rc-apps package with the flag --no-compile. I believe that the newer version of the Apps-CLI that introduced a new way that Apps are compiled with RocketChat/Rocket.Chat.Apps-cli#85, and I believe it is not compatible yet with the current version of Rocket.Chat. The --no-compile flag will make the zip contain the typescript files needed.

rowanseymour commented 3 years ago

Getting somewhere! That creates a zip with typescript files.. but weirdly when I upload it 1) it doesn't have a version 2) and it shows this error...

Captura de Pantalla 2020-11-04 a la(s) 15 49 27

I'm basically trying to create a branded version that we can publish in the marketplace. The current instructions on the RapidPro side tell users to look in the marketplace for an app called {{ brand }} Channel

paulobernardoaf commented 3 years ago

@rowanseymour This warning message occurs because the app is not registered yet on the Rocket.Chat Marketplace, the marketplace has a review process. This warning does not influence the behavior of the App.

About the missing version, have you created the branded version with the npm run build command? If so, how did you reach this page? I've created a branded version and uploaded it from both the rc-apps deploy and the manual upload, and after the installation, the version is displayed.

rowanseymour commented 3 years ago

Hi @paulobernardoaf do you know how to get an account to submit apps to the marketplace? I've tried submitting https://forums.rocket.chat/t/rocket-chat-marketplace-publisher-beta-sign-up/6093 and I've asked in open.rocket.chat but didn't get a response. Basically we can't expose this functionality to users until it's possible to follow the instructions on the claim page and install an app from the marketplace. So for now we're going to merge this and the Rocket.Chat ticketer functionality, but beta-gated so only beta users in RapidPro will see it. When we get the RC apps sorted out, then we can just flip beta-gating on the RapidPro side off.

paulobernardoaf commented 3 years ago

Hey @rowanseymour , I've talked with the Rocket.Chat team and they explained how to obtain the needed account to publish an App. You need to create an account at https://marketplace.rocket.chat/publisher/register and use it on rc-apps login.

matmsa27 commented 3 years ago

Hi @rowanseymour , we added our apps on Rocketchat Marketplace. Were you able to create the account in https://marketplace.rocket.chat/publisher/register and the publish the apps using the rc-apps login? Was that impediment the reason that the RocketChat channel and ticketer were like betas on Rapidpro?

rowanseymour commented 3 years ago

Hi @matmsa27 that was the issue. I'll have another go at creating those RC apps and if it's all good we can un-beta-gate on the RapidPro side.

Btw are you guys running code based on stable releases of RapidPro (6.0.x, 6.2.x) or tip (currently master is 6.1.x)? Is it issue for you guys that's beta-gated in master?

matmsa27 commented 3 years ago

Hi @rowanseymour , we are updating this week our stack for Rapidpro on 6.1.x version. Yeah, is this a problem to us, because we have a lot of customers that will use this integration and we need to set up these users to beta permission.

Thanks a lot for your attention Rowan, if you need help to publish the apps for Textit on RocketChat Marketplace, please tell us and we can help with RocketChat team to speed it up.

rowanseymour commented 3 years ago

Hi @matmsa27, I think I've published 2 branded versions of the app, tho oddly I got an email saying I need to Approve or Reject it (and that it will be automatically rejected in 7 days).. but there's no Approve link in the email (maybe it was stripped?) and I can't see an approve option in the Rocket.Chat UI..

Captura de Pantalla 2020-12-15 a la(s) 12 31 10 Captura de Pantalla 2020-12-15 a la(s) 12 35 16

(those aren't links I can click)

matmsa27 commented 3 years ago

Hi @rowanseymour , I will talk with RocketChat team about that and speed up to approve the versions App.

rowanseymour commented 3 years ago

Sent you an email...

fredygamez commented 8 months ago

Hello @paulobernardoaf and @rowanseymour

I'd like to thank you for your fantastic work on the RapidPro connector for RocketChat. It's an excellent tool for integrating website environments seamlessly, and your efforts are truly commendable.

However, I've encountered a hurdle in obtaining the ZIP file necessary to upload this connector to RocketChat. Specifically, I'm aiming to enable the channel connector app for RapidPro within RocketChat (I think it's a ZIP file), as detailed on the RocketChat Marketplace [https://www.rocket.chat/apps/rapidpro-channel].

It seems that RocketChat has imposed restrictions on installing and downloading apps from the Marketplace for versions prior to 6.x for some time now, particularly for RC offline versions. Despite diligent searching, I haven't been able to locate the app (ZIP file) through alternative channels online. Therefore, I'm reaching out to inquire if anyone could assist in obtaining the required ZIP file.

Could you kindly share the ZIP file with me or direct me to its location, such as a GitHub repository? Any guidance or assistance in this matter would be immensely appreciated.

Thank you for your help.