Illarion-eV / Illarion-Java

Java Applications of Illarion (Client, Mapeditor, easyNPC Editor, Downloader)
http://illarion.org
GNU General Public License v3.0
40 stars 25 forks source link

Respawn crosses have their own orbit #133

Open brightrim opened 2 years ago

brightrim commented 2 years ago

Capswick has found a bug where the respawn crosses seem to be recognized as being much bigger than their actual graphic. Any items placed above, to the right or to the left of a cross within a certain radius will be placed underneath the cross instead(as if it has its own orbit sucking in nearby objects). Same goes for auto-walking by clicking on a tile. So basically clicking the area near the cross with your mouse cursor will have the client thinking you clicked the cross instead. This is the case for both the dev and release client.

brightrim commented 2 years ago

I had a look at the graphics files and it seems the "sparkling effect" on it is making the graphic much bigger which is likely the cause. https://i.gyazo.com/4a36425f57b107c11bb89b01e45907db.png

brightrim commented 2 years ago

By cutting some of the healer.png edges to only have the main cross and shadow, cutting some of the "sparkles" end points (not really noticeable), I managed to reduce the area/orbit by about 1 tile in range so only 6 tiles are now inaccessible. The tiles that have coins on them in this image are the tiles I could hit, so any within that circle of coins that are empty can not be targeted and instead result in the item being placed under the cross or you walking as if you clicked on the cross and not the tile. Not a big issue if you are aware of it, but if you aren't it looks like the item just disappears into thin air https://i.gyazo.com/de2e71256b33a5b4db66fa5515031b8d.png

This appears to happen to some extent with all npcs(which the cross is coded for as some reason; wanting the name above it?), and was/is just far more noticeable for the cross due to it being oversized and having near invisible sparkles. Even an npc as small as Lobely still has items placed on him if you try to place an item directly north of him.

Also, despite the graphic being centered, the name of the cross (with names disabled by f12) only appears above the cross when you hover over the tile directly north of it for some reason rather than when hovering over the graphic itself. This is specific to the cross and not all npcs.