Countdown Blank

[brannonjames]

The countdown for some of the launches seem to be blank.

I did notice that the api data returns a wsstamp for each object, but for some (or possibly all) of the launches the value is just zero.

[Illu]

Hi ! Thanks for opening an issue about this 😁

You're right, I currently use the wsstamp (launch window start) value, and it looks like the API is returning a timestamp at 0 when they aren't 100% sure on the time of launch (also returned by tbdtime, which returns 1 if the API isn't sure about the time).

We can either remove the countdown timer on these launches and replace it with a "Time TBD" message, or we can remove them from the list and only display launches with a tbdtime that returns 0.

[brannonjames]

Some of the launches still seem to return a Date string, even if the API isn't 100% sure on the launch time (image below). My initial thoughts were we can just start the countdown using the utc string we get back. We could even go on to render only the "days" on the CountdownCard if all the time is zeroed out like in the screenshot above.

Thought on this?

[Illu]

I guess the CountdownCard component should handle different states, since the time displayed can be one of:

• We are 100% on the launch time
• We aren't sure of the exact launch time
• The launch already happened (accessing older launch data from the search tab)

For the first one, we can keep the current behavior. In the other cases, your idea about displaying the number of days before/since the launch would work (we could even add years or months in case of a really old launch). I think we shouldn't display it the same as when we are sure about the time though.