search

Illumina / BeadArrayFiles

Python library to parse file formats related to Illumina bead arrays
45 stars 33 forks source link

fixed zero division error in normalize_intensities #3

Closed ekarlins closed 7 years ago

ekarlins commented 7 years ago

I wrote a script to take a gtc file and output the input binary file for this program: https://github.com/gjun/verifyIDintensity The script fails for some samples due to a ZeroDivision Error in the function normalize_intensities. The script runs on all gtc files tested with the updates included here.

KelleyRyanM commented 7 years ago

Thanks. For the data provided, I think it makes more sense to return NaN. Can you review the branch at https://github.com/Illumina/BeadArrayFiles/tree/zero-division-normalization and confirm that it still satisfies your specific use case?

ekarlins commented 7 years ago

I added a review in issue #6 Should we close this issue and move discussion to issue #6 ?

KelleyRyanM commented 7 years ago

See https://github.com/Illumina/BeadArrayFiles/pull/6 for merging related change into develop branch