search

Illumina / BeadArrayFiles

Python library to parse file formats related to Illumina bead arrays
45 stars 33 forks source link

Change the order of checking the arguments in the example code. #9

Closed MinSungKing closed 6 years ago

MinSungKing commented 6 years ago

I just changed the order of the example code. Current code checks a manifest file first and then it checks whether a output file exists. Creating a manifest object takes a long time so if the output file already exists, a user wastes their time. I know it is just a example code and it is a really small thing but I think it can be better for the users.

KelleyRyanM commented 6 years ago

Thanks for the suggestion. Can you open this pull request against the develop branch instead? (I neglected to update the default branch). Alternatively, I can directly commit this change to that branch.

KelleyRyanM commented 6 years ago

Superseded by https://github.com/Illumina/BeadArrayFiles/pull/10