Closed egor-dolzhenko closed 2 years ago
Not given this a very detailed look but it sounds sensible.
You might consider whether this would be a good point to add more documentation for the new metrics outputs? Or to add a simple demo dataset which includes an example of the metrics output?
Absolutely! I already started working on documentation. I'll add it in as soon as we finalize the output file format.
This pull request will:
DiplotypePaths
toDiplotype
; this change is consistent with the underlying conceptual model where (1) a local haplotype is a graph path and (2) a local diplotype is a pair of paths; the code becomes more readable because collectionsDiplotypePaths
can now be calledDiplotypes
instead of harder-to-understand phrases likeDiplotypePathsSet
.