search

Illumina / REViewer

A tool for visualizing alignments of reads in regions containing tandem repeats
GNU General Public License v3.0
73 stars 14 forks source link

Remove error about N's in the reference context. #51

Closed bw2 closed 2 years ago

bw2 commented 2 years ago

REViewer currently throws an error and exits if the variant catalog contains a locus with N's in the reference context. This happens even if the locus with N's is different from the one specified by the --locus arg. This commit changes the logic to print the error message and skip the problematic locus instead.

sclamons commented 2 years ago

A few small things need to change: 1) Please add /bin/* to your .gitignore. We really shouldn't be committing built binaries to the repo, and I can't verify that they're safe. 2) If you're committing to the main branch, please switch back the version number (optionally with an iteration). 3) Can you make your catch statement more specific to the error you're trying to catch? As written, this could cause the program to continue through even with nasty errors like not finding the locus file.

bw2 commented 2 years ago

@sclamons I agree with your points. Since it's only a couple lines of changes and it'll be cumbersome to revert my fork to remove bin, would you mind just making this change in a different commit?