search

Illumina / interop

C++ Library to parse Illumina InterOp files
http://illumina.github.io/interop/index.html
GNU General Public License v3.0
75 stars 26 forks source link

We can no longer use this to get the instrument type. #232

Closed thrichardson-twist closed 3 years ago

thrichardson-twist commented 3 years ago

It simply returns 1024 for NextSeq1k2k and ISeq. We have both instrument types and therefore cannot distinguish between the two programmatically as we can our other instruments. Please fix this...

We're using python 3.8 and use it as follows:

run_parameters = py_interop_run.parameters()
run_parameters.read(run_folder)
instrument_type = run_parameters.instrument_type()
ezralanglois commented 3 years ago

Thank you for pointing this out. I assume you are on the latest release. I can see we lack unit tests around the RunParameters.xml for both NextSeq2k and iSeq, so I will add those while debugging this issue.

ezralanglois commented 3 years ago

This should be fixed now when the latest release is ready.