Closed Toastbrot236 closed 1 month ago
Toastbrot236
commented
1 month ago just rembered that i also added very little padding on top of the navbar to make the icons of its buttons not look cut off (which used to make especially the exclamation mark icon i chose for the future announcements page navbar button look ugly)
Toastbrot236
commented
1 month ago why are these new commits also here i dont want to merge them
IllusioQuest
commented
1 month ago why are these new commits also here i dont want to merge them
@Toastbrot236 Not sure, but might be because the pr is linked to your main branch. If you want to exclude them try creating a new branch for non-pr commits and delete them from your main branch.
Toastbrot236
commented
1 month ago alright ive created a new branch with the most unuseful name imaginable and then reverted all those commits on main, leaving them on the "wasd" branch. surprisingly this went without any issues
IllusioQuest
commented
1 month ago Ah, I forgot something important. @Toastbrot236 If you like to, you can add yourself to the "Helfende Hände" list. It's located inside the getPages method of StartView. Feel free to use a link, comment, name, style and whatever of your choice. (Maybe you want to rickroll someone... )
Toastbrot236
commented
1 month ago i have merged the changes from wasd into main just now, and while it did add some additional spaces in quite a few lines in files where i didnt put them and while it does list those last few revert commits for some reason (theyre duplicates, i suspect this happened bc this is the first time working with branches and merging for me, on top i did a few mistakes when i worked with them which i tried correcting afterwards) but taking a look at what code got published onto remote main it doesnt look too damaged or suspicious. I will redownload the source and retest it anyway right now.
Toastbrot236
commented
1 month ago looks like it's working as intended, with nothing breaking and the changes all being there
Toastbrot236
commented
1 month ago i was working on a fix for a bug i encountered yesterday right before you replied lo
Toastbrot236
commented
1 month ago bruh why does it say i had started a review i only posted a comment
the triangles next to chat message bubbles dont look detached from their message bubbles anymore and dont float infront of both the message bar and the navbar, also fixed 2 bugs with one change in the timetableNav, one being that you couldnt click the top half of any navbar buttons if the timetable page is loaded and the other one being that you now can select subjects to the left and to the right of the timetableNav, also added some comments for the classes in the views folder, a few improved tab titles and a very minor refactoring (all i did was to move one of the chat classes, forgor which one, together with its folder from the view folder to the views folder), maybe theres some other very minor changes i forgot.