IllusionMods / AnimationLoader

GNU General Public License v3.0
24 stars 3 forks source link

NullRef when starting Studio with chara studio disabled in plugin settings #25

Closed DeathWeasel1337 closed 2 years ago

DeathWeasel1337 commented 2 years ago

To reproduce, open plugin settings disable "Character Studio", close game and start Studio. This error prevents Studio from loading.

NullReferenceException: Object reference not set to an instance of an object void AnimationLoader.SwapAnim+Hooks.LoadStudioAnims(Info, IEnumerator)+()➞ void bool AnimationLoader.Extensions+d1.MoveNext() void IllusionFixes.StudioOptimizations.RunCoroutineImmediately(IEnumerator) void IllusionFixes.StudioOptimizations.RunCoroutineImmediately(IEnumerator) bool IllusionFixes.StudioOptimizations+d12.MoveNext() void UnityEngine.SetupCoroutine.InvokeMoveNext(IEnumerator, IntPtr)

ManlyMarco commented 2 years ago

Sounds like it works as intended, studio gets disabled.

IDontHaveIdea commented 2 years ago

AnimationLoader.KoikatsuSunshine_v1.1.1.1.zip

Here is a fix.

This was done because of the load times in Sunshine were so bad. In KK case the option is not there.

Do I leave it as a feature and added to Koikatu or remove it.

DeathWeasel1337 commented 2 years ago

Thanks for the fix. The only reason I used the feature is because of the long load times, as far as I'm concerned it can go away now that the load times are fixed.