search

IllusionMods / BepisPlugins

A collection of essential BepInEx plugins for games made by Illusion.
GNU General Public License v3.0
383 stars 82 forks source link

[EC] - [coordinate cards does not load correctly at adv scene] #166

Open ORGN-G opened 2 years ago

ORGN-G commented 2 years ago

Describe the bug EmotionCreators Version 1.1.7 BepInEx 5.4.21 EC_sideloader.dll 16.3 or later

When I specify a coordinating card in adv, the character's outfit changes. There is no problem here. However, if I then save the scene, restart EC, and then load the same scene, the sideloader mod outfit does not load correctly.

This problem has been occurring since version 16.3 of sideloader and is assumed to be caused by "UniversalAutoResolver" in Core.UAR.cs. I built sideloader.dll with CurrentSlotID = BaseSlotID instead of randomizing CurrentSlotID in the relevant part of the latest code and the problem did not occur.

To Reproduce Steps to reproduce the behavior:

  1. Create a coordinate card containing the zipmod outfits
  2. Create a scene with Title -> Make(メイク) -> Scene(シーン) -> New(新規)
  3. Add an ADV part and apply the coordinate card created in (1) to the character.
  4. Save the scene and exit EC.
  5. Restart EC and load the saved scene.
  6. Open the ADV part. Applied costumes do not display properly.
ManlyMarco commented 2 years ago

Sounds like sideloader data isn't getting saved in this case. This sort of thing was exactly why the randomization was put in. It might look like it worked before but the outfit would break some time later when your mods folder changed or you tried sharing it. I'm not sure if there will be any takers for this unless someone on the discord server in the EC channel picks this up, I suggest asking there. I can offer hints to anyone trying to fix it.

ORGN-G commented 2 years ago

Thanks for your reply. It looks more like a loading issue than a save to me, as sometimes an outfit loads as a different outfit. At least with sideloader, which I modified to not randomize, I can save/load with no problem. If it's too difficult to devote time to the EC, and I know it causes other problems, but could you please add an item in the plugin menu to turn randomization on or off?

I asked on Discord before opening this issue, and while some people found similar problems, no one seemed to know the solution.

ManlyMarco commented 2 years ago

Added a bandaid solution for now until someone makes a proper fix https://github.com/IllusionMods/BepisPlugins/commit/5e5ffc6276749e8282cbdaddde37f4c6df99c238