IllusionMods / HSPlugins

MIT License
50 stars 36 forks source link

[timeline]vital issue, after use function"group together", when changing chara, timeline will be unable to play. #26

Closed mrxuzhen closed 2 years ago

mrxuzhen commented 2 years ago

Many timeline author like to use function "group together" to make interpolables logically assessable. But in hf-patch's timeline, after using "group together" function before I replace the chara, the whole timeline will be messed up. Those interpolables will be blended into together and I can no longer delete replaced chara. The whole plugin will be broken. Actually in original version of timeline by joan6694 have no such a big problem, though his version have many bugs, but none of them are so vital.

In logs there wil be many loop error. And most importantly, when using latest timeline to make a scene card, such a problem will sustain, even this card is loaded in old version of timeline. That means when such issue happens, the card saved in latest timeline plugin will never be able to replace charater.

NullReferenceException: Object reference not set to an instance of an object at HSPE.AMModules.DynamicBonesEditor/TimelineCompatibility/<>c.b1_14 (string,Studio.ObjectCtrlInfo,object) <0x00055> at Timeline.Interpolable.get_name () <0x00059> at Timeline.Timeline.ShouldShowInterpolable (Timeline.Interpolable,bool) <0x0008d> at Timeline.Timeline/<>cDisplayClass173_0.b__1 (Timeline.LeafNode1<Timeline.Interpolable>) <0x00031> at Timeline.Tree2<Timeline.Interpolable, Timeline.Timeline/InterpolableGroup>.Any (Timeline.GroupNode1<Timeline.Timeline/InterpolableGroup>,System.Func2<Timeline.LeafNode1<Timeline.Interpolable>, bool>) <0x00151> at Timeline.Timeline.UpdateInterpolablesViewTree (System.Collections.Generic.List1,bool,int&,int&,single&,int) <0x009fc> at (wrapper dynamic-method) Timeline.Timeline.DMD (Timeline.Timeline) <0x0013e> at Timeline.Timeline.RemoveInterpolables (System.Collections.Generic.IEnumerable`1) <0x002d5> at (wrapper dynamic-method) Timeline.Timeline.DMD (Timeline.Timeline) <0x00605>

(Filename: Line: -1)

DefectoDetecto commented 2 years ago

For me, after "group together" I can replace characters without any problem. I'm also using the latest hf-patch's timeline. Maybe you need to provide more specific information to reproduce the issue? or a scene file

mrxuzhen commented 2 years ago

https://mega.nz/file/wssHmCZL#DcONfEMKRvJmLCPDU3aOBj5PW67NokKEyPSh8Q1k6VI this is a charged scene card by yuukis so please don't leak it elsewhere.

ManlyMarco commented 2 years ago

Can confirm, the error is reproduceable. Will look into it later.

mrxuzhen commented 2 years ago

there are some other bugs which is not that vital. Such as after "group together", when I tried to ungroup them, I can't just "parent to nothing" them. After "parent to nothing" them, there will be 2 same interpolables at same time, one in group, one outside the group. After save and load there will be only 1 left, I mean the upper one. That makes ungroup process very complicated.

DefectoDetecto commented 2 years ago

Seems that the same issue can be reproduced even with Joan's original 1.1.0 version.

mrxuzhen commented 2 years ago

No, maybe it is me who didn't describe it clearly. the broken scenes, whatever what version of timeline the "who load the scene" have, the studio will be broken, old or new, it doesn't make a difference. But if you are MAKING scene cards in hf's latest version of timeline, and you use the group together function, the scene card will be broken once saved. Thats different. It means the card is broken when make in latest version. In manlymarco's original version, when card is make in same way, this problem will not happen. There must be something different between original version and latest version in group together function. There are more and more scene maker are puzzled by this bug.

DefectoDetecto commented 2 years ago

I know what you're talking about. But below is the process I tested. I downloaded a timeline scene created nearby after the 1.1.0 release, used "Group together" with Joan's origianl 1.1.0 Timeline, saved it, and then loaded it. The same issue happened.

If this issue didn't exist two years ago, it could be due to changes in the studio plugin environment. Plugins sometimes interfere with other plugins. And there are a lot of plugins that work in the studio, and a lot has changed over the past two years. But no. I tested it with the HF patch from 2 years ago. This issue has always been there.

mrxuzhen commented 2 years ago

Well, to be honest that I am using 1.1.0 to create scenes for long. Here is one of my scene. Could you have a try on this scene? I can't make same issue happens to it actually. 2022_0927_1653_43_097

DefectoDetecto commented 2 years ago

timeline Timeline 1.1.0(So, there is no Timeline button in the left corner) with the HF patch from 2 years ago.