search

IllusionMods / IllusionFixes

A collection of fixes for common issues found in games by Illusion
GNU General Public License v3.0
160 stars 29 forks source link

Male face type fix #27

Closed OrangeSpork closed 3 years ago

OrangeSpork commented 3 years ago

Illusion hides the face type selections for males in chara creator (as they don't ship any). We've got modders looking at adding more male face types...this just pops the apparently perfectly functional UI back to active state.

ManlyMarco commented 3 years ago

Looks good, just have a couple nitpicks.

  1. Does it need to run in female maker? Checking for maker sex in the patch would save some cycles.
  2. Does it work in pre-darkness / KKP? If you don't have a way to test it then send me a build on discord or here.
  3. You can reference KKAPI since it exists on most game installs, a couple other plugins in this repo reference it to avoid duplicate code/patches.
OrangeSpork commented 3 years ago

1 - Good point and no we do not. 2 - This is just an HS2/AI problem. KK has the male face type selector working out of the box. Just HS2/AI Illusion decided to just hide the option they weren't using. 3 - Oh it wasn't listed as a dependency so I didn't want to inject it but if it's already implied than hell yes, so much more convenient...