search

IllusionMods / IllusionFixes

A collection of fixes for common issues found in games by Illusion
GNU General Public License v3.0
157 stars 29 forks source link

[KKS] Main Game Optimizations causing "stiff" characters mid-scene #34

Closed Avvilimento closed 2 years ago

Avvilimento commented 2 years ago

I have noticed that some of the animation on the girls within a sex scene ceases under some circumstances, most notably the hair and breasts. Following some experimentation I've been able to narrow it down to the various dynamic bone update features provided by the main game optimizations. My theory is that these optimizations are remaining in effect during the scene but the character and camera positions used to determine what, if any throttling of the dynamic bone calculations is to be done is still based on their "world" positions. As such, as soon as the "action" moves too far away from the starting point or would otherwise be obscured (depending upon which optimizations are in use) the dynamic bones simply stop.

Given the nature of the optimizations and the scenes involved it would make more sense that they simply be disable during such scenes, rather than attempting to dynamically update the player and camera locations. This would allow for the retention of the optimization outside of the scenes to improve frame rates without any edge cases needing to be catered for.

Testing conducted with BepinEx v5.4.19 and Illusion Fixes v19.2.

ManlyMarco commented 2 years ago

Can you check if this build fixes the issue? KKS_Fix_MainGameOptimizations.zip

Avvilimento commented 2 years ago

Unfortunately it doesn't appear to have fixed the issue. To be honest my brief testing didn't show any difference at all, though this time I did at least confirm that adjusting the range would indeed cause or correct the issue without adjusting the scene or changing position.

In the interest of full disclosure (though you likely already suspected as much) I am running the base "BetterRepack" R3, with Stiletto enabled (though disabling it makes no difference).

ManlyMarco commented 2 years ago

I think I've got it, this one should work. KKS_Fix_MainGameOptimizations.zip

Avvilimento commented 2 years ago

Not a fully comprehensive test by any means, and the non-deterministic nature of the game means I couldn't replicate identical circumstances, but it looks very promising. Adjusting the range caused no problems and a few quick tests suggested starting camera angle wasn't causing issues either.