IllusionMods / KKManager

Mod, plugin and card manager for games by Illusion that use BepInEx
https://www.patreon.com/posts/41869238
GNU General Public License v3.0
443 stars 70 forks source link

Add option for mods that "will be removed" to move them into a My Mods folder instead #175

Open AliceChurchfield opened 3 months ago

AliceChurchfield commented 3 months ago

Feature For mods that get flagged for removal during a mod update, allow the user to specify that they instead be moved into a folder called "My Mods" rather than deleting them.

Optionally: if the mod's file name starts with text between square brackets, move the mod into a subfolder inside My Mods whose name is that text. For example, if I have a mod called [anse] jnco_pants v3.8.1.zipmod, then it would be moved into a folder called anse inside My Mods.

Why this Would Be Nice It's not obvious that we're supposed to put mods we downloaded into a separate folder to keep Chikarin from wanting to nuke them. This would mostly just be a usability (especially for new users) and quality-of-life feature.

ManlyMarco commented 3 months ago

I think an easier fix would be to put a 'Do not put zipmods into Modpack folders.txt` file or similar inside the mods folder.

ManlyMarco commented 3 months ago

Related #95 #128

ssj4maiko commented 3 months ago

A question. I do the MyMods things myself, however, I notice files being deleted and I usually check on them. Sometimes I see that there is a newer version, so deleting the previous version makes sense. I have also others being transferred from one category to another.

But I also see some being deleted, and no newer version, and go to check and see that an entire folder is being deleted (usually with few mods) and stuff. At least there is a way to find duplicates (HS2FND), so after saving the files to be deleted, I use that to find the duplicates/older versions, and delete the non Sideloader Modpack version

ManlyMarco commented 2 months ago

@ssj4maiko This would be a question for maintainers, usually it's either the mod being replaced with a different mod that includes it, or being removed on a request of the author.

I'll see about detecting that the mod is removed because of a newer version and display that in the interface.

ManlyMarco commented 1 month ago

The fix to detecting updated zipmods I mentioned is included in https://github.com/IllusionMods/KKManager/releases/tag/v1.3.1

ssj4maiko commented 1 month ago

Oh, so that's why last time I checked there were a bunch of delete only files after I had updated it fully. I'll check each case individually once I'm able to.

ssj4maiko commented 1 month ago

Finally had the time to check on it, I confirmed that the items selected to be removed were not duplicates. They were items from: [g7o827] Liangpi Lurki ROC TheAlex and Blake

I suppose these authors have removed these items themselves then?

ManlyMarco commented 1 month ago

That or requested removal I guess, it's a question for https://github.com/BetterRepack/SideloaderModpackTracker/issues