IllusionMods / KKS_VR

VR plugin for Koikatsu Sunshine (main game and studio)
MIT License
52 stars 12 forks source link

Appearing upside down after a date #21

Closed RodoxVR closed 1 year ago

RodoxVR commented 2 years ago

When u say tourism Together with a girl and when the random spot is the waterfall u are flipped upside down when diaglogue ends.

Atleast the camera is... the character is still standing on the ground.

momspaghetti123 commented 1 year ago

Can confirm. The mod works great and I highly appreciate the creator of this fork... But this bug screws up the game not even a full day in. Eventually I got stick and started walking outside the map, till the game crashed.

Really hope this will get fixed sometime. This is quite a fun way to play - but this makes it unplayable.

RodoxVR commented 1 year ago

Yeah, and i found out that its not only on the waterfall, it seems its random at times, plus on occassion it does it also after loading the map is finished when first entering the world.

ManlyMarco commented 1 year ago

Does this only reliably happen when being asked by the girl to go to the waterfall scene or can you suggest it too? Send output_log after triggering the issue.

momspaghetti123 commented 1 year ago

Suggesting works too, sometimes it just happens even if you initiate a chat with any girl. I don't know if any other scenes have this bug as well, but so far I only start experiencing the bug while in the waterfall scene. output_log.txt Here's the output_log.txt of the game where I started experiencing the upside down crash until I got stuck into an object, managed to get outside the playable area and eventually crashed.

ManlyMarco commented 1 year ago

@momspaghetti123 One of the characters is using a bugged hair piece spamming the log and probably slowing down the game. Looks like I'll have to reproduce it to have a shot at debugging it.

ManlyMarco commented 1 year ago

@RodoxVR @momspaghetti123 What VR headsets are you using?

momspaghetti123 commented 1 year ago

@RodoxVR @momspaghetti123 What VR headsets are you using?

Oculus Rift S - Playing through SteamVR.

RodoxVR commented 1 year ago

@RodoxVR @momspaghetti123 What VR headsets are you using?

I'm using Vive Pro 2 with Steam Index controllers.

Also on SteamVR.

RodoxVR commented 1 year ago

As promised... i donated some money for your time on your patreon page. (Although my name there is not RodoxVR its Not_Today)

You are a legend for making this mod, u have my gratitude.

ManlyMarco commented 1 year ago

Can you test if this build works any better? KKS_MainGameVR.zip Send the output_log if it doesn't (immediately after the bug happens). For some reason I can't reproduce the issue.

momspaghetti123 commented 1 year ago

On it 🫡

ManlyMarco commented 1 year ago

Latest build KKS_MainGameVR.zip

RodoxVR commented 1 year ago

Here's my log:

output_log.txt

Description: asked a girl outside the school building to tourism together and the place was waterfall, it did the upside down thing again, after this i quit the game.

Used the latest build 2 hours ago from this post above, play session was about 1 hour and 30 min before it happened, i kept asking to do things together till it happened.

Not sure if u are aware but when start talking to a girl now the camera is zoomed out very far outside the map but when i say something to girl camera resets to the correct position, this happens only after using the new build.

Hope this is helpful.

ManlyMarco commented 1 year ago

Oops, I forgot to mention you need to change the Log level setting of KKS_MainGameVR in plugin settings from Info to Debug (restart the game afterwards). Sorry about that, without that the log doesn't show the info I need.

The outside of map issue should be fixed in the latest build I posted above, not sure why it happened if you used it.

So the issue now happens only very rarely? Or is it the same as before?

RodoxVR commented 1 year ago

Alright,

Then we'll just have to try again, not a big problem. I do not have time tomorrow but in the weekend ill have another go.

ManlyMarco commented 1 year ago

Latest build, more changes to positioning code, and title skybox KKS_MainGameVR.zip

momspaghetti123 commented 1 year ago

Tested out the latest build, and experienced the bug not even much in, less than 30 minutes of playing. Happened right after a date ended, and then I quit the game. output_log.txt

Some feedback regarding other changes of this build: VR title skybox looks nice, I approve.

There are some peculiarities regarding the updated positioning code: The camera bug that Rodox had mentioned still happens, your camera moves way outside the map when you initiate chat with a girl. It then "fixes" itself, after you do any kind of talk, but your camera gets moved behind the girl, so it's better, but not quite there. However, before this incorrect position, the correct camera pos with the girl facing you appears for a split second. The far-outside the map camera bug only happens when you talk to a girl the first time in a particular map, subsequent encounters in the same map move your camera to the last (almost correct) position that you were in with the previous girl. The far-outside camera bug reappears after changing map. Interestingly enough, the camera behaves differently after initiating a date. The camera position is almost right, but super close to the girl in dates. The camera position remains this way until you try to turn with the School tool, at which your camera gets transported to a random place in the room (height still correct and hadn't yet experienced out-of-bounds, though). Camera moves back to the almost-correct-but-way-too-close pos after progressing the convo, till/if you try to turn again.

Hope all this will be useful, thanks for the work and cooperation.

ManlyMarco commented 1 year ago

Alright, I THINK it's actually fixed now KKS_MainGameVR.zip Fingers crossed.

Edit: Final v2, mostly logging changes, otherwise should be the same as above KKS_MainGameVR.zip

RodoxVR commented 1 year ago

Used Build: KKS_MainGameVR Final v2 ^ Ive send both main directory output log and the bepinex log, as im not sure wich one to send u. Might be both helpful ?

Here's my output log:

output_log.txt

Here's Bepinex Log: LogOutput.log

Description:

Played about 1 hour 30 min again, invited girl to tourism together, after the second time that the waterfall date appeared the camera went upside down "After date was finished", so it doesnt always do it. But its almost always the waterfall that it happens. After that i quit the game.

Camera bug when u go talk to a girl spawns in wrong but not outside map anymore, sometimes its correct but most of the time it spawns on her side (near her) or behind her back or looking away from her.

So the distance is good now just not the correct location and camera looking angle i believe.

ManlyMarco commented 1 year ago

I see no reason for it to still happen, and I still can't reproduce the issue. The waterfall events work fine for me. Send your game save with exact steps on how to reproduce the issue, ideally within a couple of minutes not hours.

RodoxVR commented 1 year ago

save: https://mega.nz/folder/PPQ1xL7a#QzBBwdJPU1CtIOVAhUbUzg

Well it happened also on my old pc, it has always done it with multiple saves.

Have the latest better repack from [ScrewThisNoise] Koikatsu Sunshine EX BetterRepack R9 As i'm always using those. Then:

  1. increase relationship status to increase chance she says yes for tourism together.
  2. ask girls to go tourism together untill waterfall scene.
  3. if it doesnt go upside down try again as it doesnt always trigger the bug.

it sometimes takes multiple times to trigger it so be patient.

momspaghetti123 commented 1 year ago

I will test out as well to see if I concur.

momspaghetti123 commented 1 year ago

Yum, I see Crossfader was implemented to the plugin. I could test it out together with the tests for the bug right now. Does it conflict with KKS_Crossfader (do I need to uninstall that?)?

Edit: Checked code and seems it shouldn't. If you will be sending a new build, I will test that out.

momspaghetti123 commented 1 year ago

Can concur. It didn't even take long, even though I wasn't rushing to get the bug. Couldn't find the BepInEx log that was supposedly going to be generated - but found that the output_log.txt did get all the VR debug details so uploading that. This time it happened after ending a date in the waterfall, like usual. To note, last time I experienced the bug, it was in a room where the date took place in. What might help with catching this bug: either the camera also gets the yaw inverted, or the controls also glitch, because when I enter a map in the upside-down state, pressing forward on the joystick again brings me back to the previous room, instead of me traversing away from the exit/entry point, like it would usually be.

output_log.txt Also: Camera positioning is almost entirely fixed: Though the camera position should update after initiating a chat with a girl, not only after doing any first action during the chat. Dating has the too-close camera, which gets fixed after you try to turn with the School tool, moving back to the too-close camera after the next line is said.

ManlyMarco commented 1 year ago

The thing is I completely strip rotation other than facing left/right so it shouldn't be possible to get flipped. What's does the too close camera look like?

RodoxVR commented 1 year ago

Maybe there is an alternative way to solve the issue sort off, perhabs make a button in the kks_maingameVR plugin menu where u can flip the camera to the right position again ?

As im not a programmer... i don't know if this is reasonable to ask.

ManlyMarco commented 1 year ago

There's a good chance this got fixed in v1.2. If anyone is able to verify, please let me know.

RodoxVR commented 1 year ago

First of all Marco, what a great update! So many fixes.

Especially the AnimationCrossFader is a welcome edition for some extra boob jiggle :3 and the fact that i can now open the menu without touching the mouse, u truly are a wizard.


Now about this appearing upside down bug, i have not noticed it during my test session yesterday... but i only got the waterfall scene twice so it needs more extensive testing.

The camera still doesnt face the girl when u start talking, a minor issue that i can live with for now as it corrects itself when u continue the conversation.

All in all great job, looking forward to my next play test when i have more time.

momspaghetti123 commented 1 year ago

Sorry for the late reply, been busy. I've tested out the update and played through two in-game days. Happy to confirm that it's very likely fixed, as I have not ever been able to get past the first day without catching the bug. Highly appreciate the binding fixed as well, as I can now warp and save.

Camera is still very wonky and inconsistent between dating and talking. But thankfully, as Rodox has mentioned, it gets corrected after initiating the first line.

I'd recommend a H scene controls rework (or at least more customizability for the bindings like multi-buttons and mode switches) and setting fade to black, but I can open issues for that, and potentially even do a PR or two.

This issue can be closed. I will be donating for the awesome work.

ManlyMarco commented 1 year ago

Nice, that's one annoying bug down. The camera thing is the second most annoying bug to fix because of how janky the whole setup is. I bet it could be fixed for good by a rewrite but that's a ton of work that I don't feel like doing for the little return.

Definitely make new issues for the suggestions, and I'd absolutely love some PRs :)