search

Ilogeek / redmine_issue_dynamic_edit

Allows users to dynamically update (AJAX) issue's attributes from issue details page without any refresh (JIRA like)
http://www.redmine.org/plugins/redmine_issue_dynamic_edit
MIT License
134 stars 56 forks source link

Request - Integration with Quick View plugin #26

Closed Hasgassa closed 5 years ago

Hasgassa commented 6 years ago

I'm sorry but I don't know how to open a request, so I'm submitting an issue.

I really enjoy and use your plugin a lot, and I have an improvement idea for it, that would improve Redmine's productivity a lot.

Is it possible to make it to work with Quick View plugin, allowing to edit fields directly in the pop up window provided by Quick View plugin?

Thank you

Ilogeek commented 6 years ago

Hello @Hasgassa

I'm happy you find the plugin helpful !

I've installed http://www.redmine.org/plugins/quick_view and updated /plugins/quick_view/app/views/quick_view_issues/quick_view_issue_dialog.html.erb file with this content. The result is similar to (Display may change depending on your theme) : Result

If this is the feature you want for your plugin here's how to add it :

Hasgassa commented 6 years ago

Hello @Ilogeek and thank you very much for the enhancement, it is exactly what I was talking about!!! :)

Btw and hopefully this can help other users, in order to make it to work with Redmine 3.4 I had to replace line's 78 function. The line was changed accordingly: Original code: <%= render_custom_fields_rows(issue) %> Corrected code: <%= render_half_width_custom_fields_rows(issue) %> I don't know if this is the right fix to do but it is how I fixed it.

Regarding to this new feature, I've detected a limitation that would be great if it could be overcome. I use Redmine Checklists plugin (Light version) and despite of being able to see and press the checklists' check boxes, it makes no effect and does not save the changes. I use the checklists to automatically calculate and change the "% Done".

The last but not the least, maybe this is not the right place to do it but If you allow me to request another enhancement, it would be great if the Quick_View window would work in Gantt chart (I use Easy Gantt plugin, not the PRO version). In my opinion, the only real Redmine's limitation is the static Gantt chart. If Quick_View and Dynamic_Edit would work with Easy Gantt plugin it would be something huge.

Once again thank you for your work, it's really helpful!

Ilogeek commented 6 years ago

Hello @Hasgassa

Thank you for your feedback about the modification. I'm happy if it feets your need! Just to be sure, in which file did you make this modification? Was it on https://gist.github.com/Ilogeek/e0b4da18397ee095adbebdd4b4046eab#file-quick_view_issue_dialog-html-erb-L84 (L.84) ?

My plugin only supports regular fields and fields managed directly by Redmine (custom fields). I will install Checklists and try to find a way to support it if installed on the Redmine instance.

Your last request concerns Quick view plugin. I would suggest to contact directly the owner of the Quick View plugin. I don't own it and I'm not an expert so I think it's better if the modification is done by him. If you have IT skill don't hesitate to check its source code and discover how it works to implement it for Gantt plugin.

I'll come back to you after my tests with the Checklists plugin!

Ilogeek commented 6 years ago

Hello @Hasgassa

I updated my code on : https://gist.github.com/Ilogeek/e0b4da18397ee095adbebdd4b4046eab . It now supports Checklists plugin (but still not optimal, i think there's a better way to handle JS sources from plugins)

If you find the plugin helpful, please take a minute to star it on Github and rate it 5 stars on http://www.redmine.org/plugins/redmine_issue_dynamic_edit 👍

Hasgassa commented 6 years ago

Hello again @Ilogeek,

Thank you again for your efforts. It works now on the quick_view window!!! :)

As you mentioned, it's not working perfectly with this Checklists plugin, it has some limitations. For example, I've detected that when I tick a checklist checkbox, after that I cannot update a common field until I refresh issue's page, using quick_view or native issues window. It just starts hanging. Anyway, it's something I can live with, your plugin is great!!! 👍

Answering to your question about the edited line, the line I've edited is not present anymore on your file. You may find it here: https://gist.github.com/Ilogeek/e0b4da18397ee095adbebdd4b4046eab/revisions#diff-bf10ee2a44be87f064d116ce7108bc14L84

In what regards to Quick_View and Gantt synergies, unfortunately I'm not an expert in Web programming. I was trying to reach a way to contact Quick_View's developer but I couldn't.

Thank you once more!

Ilogeek commented 6 years ago

Hi @Hasgassa

I've updated the plugin with a better way to support automatic updates (such as Checklists performs) Feel free to install this new version and then update your Quick_View template with this new code : https://gist.github.com/Ilogeek/e0b4da18397ee095adbebdd4b4046eab (new variable at line 35)

Don't hesitate to come back here if you have any problem with this update 👍