Ilogeek / redmine_issue_dynamic_edit

Allows users to dynamically update (AJAX) issue's attributes from issue details page without any refresh (JIRA like)
http://www.redmine.org/plugins/redmine_issue_dynamic_edit
MIT License
134 stars 56 forks source link

Doesn't allow editing 2 times on the same page consiquently #28

Closed larinam closed 5 years ago

larinam commented 6 years ago

Have a problem on the frontend with this plugin. After editing any field or different fields more than one time, I receive the following issue.

screenshot 2018-08-29 15 38 59
Ilogeek commented 6 years ago

Hello @larinam

Thank you for your feedback. Unfortunately I can't reproduce your issue right now. Could you please answer these questions below and we will find a way to fix your issue :

larinam commented 6 years ago
screenshot 2018-08-30 09 11 37 screenshot 2018-08-30 09 17 30 screenshot 2018-08-30 09 19 12

Regarding the fourth question - no, this happens with any field, e.g. description or issue title.

Ilogeek commented 6 years ago

Hello @larinam

Thank you for your complete return that helped a lot.

It looks like this problem happens when you have a plugin that edit issue value automatically (Computed custom field plugin in this case). An other user has the same kind of problem here #26 with Checklists plugin.

By editing automatically a field in your Redmine issue it creates a new state for your Redmine issue and when my plugin tries to update it, a conflict is raised.

I will update my plugin to avoid this situation and I'll come back to you

larinam commented 6 years ago

Hello @Ilogeek,

I'm happy to hear that, looking forward.

Ilogeek commented 6 years ago

Hi @larinam

I've updated the plugin with a new way to handle conflict with other modification on the Redmine issue. Feel free to install the last version and come back here if you have any problem with it and we will find a solution!

larinam commented 6 years ago

Hi @Ilogeek ,

There's no exception any more, but:

  1. Changes are not saved to the database
  2. Pencils are multiplied on the page with every change :)

Zipped video is attached.

DontSave&MultiPencil.mp4.zip

ddk85 commented 5 years ago

Same trouble with pencils :)

Also cann't change due date.

isndev commented 5 years ago

@Ilogeek , please fix the issue

TrumanRu commented 5 years ago

The same problem.

Ilogeek commented 5 years ago

Hi,

(Thank you all for your last comments with great info helping the community resolves the issue. Don't hesitate to commit your PR if you find any solution)

It sounds like there are some conflicts with other plugins such as "A common libraries" ( Eg: #42 ) This may cause your issue here, do you also use this plugin ?

I've updated the plugin and tried it with the last Redmine version vanilla (any plugin installed) and it works fine.

This plugin may alter default select elements or datepicker elements and give this kind of behavior. I'll check it by installing it

dirmax commented 5 years ago

Hi,

Use version 2.5.3 of a_common_libs. Don't activate option "~Включить ajax загрузку формы редактирования задачи" (missed english label :) in settings

Ilogeek commented 5 years ago

Hi @dirmax

Well done, i've just tested your solution and it works like a charm !

On the "A common libs" settings page on your Redmine instance administration (settings/plugin/a_common_libs) uncheck the last element that appears in Other setting (which is not translated). It's a setting named enable_ajax_edit_form in the code, "Включить ajax загрузку формы редактирования задачи" as current label (it's not translated in the plugin) :

Uncheck the last element You can then apply your modification