Ilogeek / redmine_issue_dynamic_edit

Allows users to dynamically update (AJAX) issue's attributes from issue details page without any refresh (JIRA like)
http://www.redmine.org/plugins/redmine_issue_dynamic_edit
MIT License
134 stars 56 forks source link

Redmine WYSIWYG Editor compatibility #98

Closed alterdaemon closed 1 year ago

alterdaemon commented 1 year ago

repo link: https://github.com/taqueci/redmine_wysiwyg_editor/network

pr-dtakac commented 1 year ago

I think I found the bug. After my changes it's finally working. I also made small change in css, because when I for example have some bigger image in issue description, after switching to preview in dynamic edit modal position of this modal was bad (toolbar wasn't visible).

@Ilogeek can you check this and add similar fix in next release?

--- a/assets/javascripts/issue_dynamic_edit.js
+++ b/assets/javascripts/issue_dynamic_edit.js
@@ -151,7 +151,7 @@ var cloneEditForm = function(){
                        cfg.height = 100;
                        CKEDITOR.replace("issue_description_dynamic", cfg)
                }else if (typeof(jsToolBar) === typeof(Function)) {
-                       var wikiToolbar = new jsToolBar(document.getElementById('issue_description_dynamic')); wikiToolbar.draw();
+                       var wikiToolbar = new jsToolBar(document.getElementById('issue_description_dynamic')); wikiToolbar.setPreviewUrl('/preview/text'); wikiToolbar.draw();
                }
        }

--- a/assets/stylesheets/issue_dynamic_edit.css
+++ b/assets/stylesheets/issue_dynamic_edit.css
@@ -56,7 +56,8 @@ body.controller-issues.action-show .dynamicEditField {
        opacity: 0;
        transition: opacity .3s ease-in;
        /* left:0; correct position on top of icon */
-       bottom: 100%;
+       /*bottom: 100%;*/
+       top: 10%;
        margin-bottom: 5px;
        box-sizing: border-box;
        padding: 10px;
Ilogeek commented 1 year ago

Hello @pr-dtakac

Thank you for your feedback and investigation This issue may have the same problem : https://github.com/Ilogeek/redmine_issue_dynamic_edit/issues/100 and my last commit may have solved it

Don't hesitate to come back to me if you have any difficulty

If you find the plugin helpful, take a minute to star it on Github and rate it 5 stars on http://www.redmine.org/plugins/redmine_issue_dynamic_edit 👍