Should we keep constraints for Java's BigInteger/BigDecimal?

Iltotore / iron

Strong type constraints for Scala

https://iltotore.github.io/iron/docs/

Apache License 2.0

430 stars 38 forks source link

Should we keep constraints for Java's BigInteger/BigDecimal? #145

Closed Iltotore closed 1 year ago

Iltotore commented 1 year ago

This PR #136 brings constraints for BigInt/BigDecimal and their Java counterpart in the standard constraints library.

Since Scala already has BigInt and BigDecimal, I don't think we need to support Java's ones too. @ajaychandran, since you're the author of the PR mentioned above, what's your opinion?

ajaychandran commented 1 year ago

In hindsight, I probably should not have added it given Java numeric boxed types are not supported. Feel free to remove the associated instances.