IlyaSemenov / grammy-scenes

Nested named scenes for grammY
MIT License
27 stars 0 forks source link

Store step name instead of position #13

Closed IlyaSemenov closed 1 year ago

IlyaSemenov commented 1 year ago

Currently, the stack frame stores the position of the step which called wait():

https://github.com/IlyaSemenov/grammy-scenes/blob/84a1082d43441a2cebdc8b85bfb09facc49e681e/src/types.ts#L12-L17

https://github.com/IlyaSemenov/grammy-scenes/blob/84a1082d43441a2cebdc8b85bfb09facc49e681e/src/scenes_manager.ts#L118-L121

As I elaborated in #1, this approach is easy to use for the developer but breaks UX for users that were in the middle of a scene when it gets slightly updated and the step positions shift. If we store step names instead of positions that will be much more reliable (and we could even allow developers to add optional fallback steps for legacy users).

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 10.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: