IlyaSkriblovsky / txredisapi

non-blocking redis client for python twisted
Apache License 2.0
235 stars 91 forks source link

Add support for a Script class #102

Open offero opened 8 years ago

offero commented 8 years ago

I made this object for my own use that mimics the one from the redis-py driver: https://bitbucket.org/wanderua/wanderu.bamboo/raw/74aeda47a1764284d137fec437d73eb8047d5b98/wanderu/bamboo/txscript.py That's from an open-source project that I am making for using Redis as a queuing mechanism with reliability. I would gladly contribute it or some version of it to the core library if you think that would be useful.

The redis driver has a Script class that is pretty useful: https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L2676

fiorix commented 8 years ago

That's cool, contributions are definitely welcome. I haven't been maintaining this and any of my previous python code, but would be happy to review and eventually take patches. @IlyaSkriblovsky has been more actively.

As far as the script capabilities of redis, yes, aware of them... implemented this in my go-redis driver a while back.

On Feb 9, 2016, at 10:23 AM, Chris notifications@github.com wrote:

I made this object for my own use that mimics the one from the redis-py driver: https://bitbucket.org/wanderua/wanderu.bamboo/raw/74aeda47a1764284d137fec437d73eb8047d5b98/wanderu/bamboo/txscript.py https://bitbucket.org/wanderua/wanderu.bamboo/raw/74aeda47a1764284d137fec437d73eb8047d5b98/wanderu/bamboo/txscript.py That's from an open-source project that I am making for using Redis as a queuing mechanism with reliability. I would gladly contribute it or some version of it to the core library if you think that would be useful.

The redis driver has a Script class that is pretty useful: https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L2676 https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L2676 — Reply to this email directly or view it on GitHub https://github.com/fiorix/txredisapi/issues/102.

IlyaSkriblovsky commented 8 years ago

Please make the PR from this nifty piece of code!