search

IlyaSkriblovsky / txredisapi

non-blocking redis client for python twisted
Apache License 2.0
235 stars 91 forks source link

Add ssl option to connection #148

Closed roeltm closed 1 year ago

roeltm commented 1 year ago

Continuation of https://github.com/IlyaSkriblovsky/txredisapi/pull/147.

Went throught the comments from @IlyaSkriblovsky and tested it with the attached example code.

roeltm commented 1 year ago

Have you tested these changes in the real life?

yes, for others if they want to test:

  1. Generate a CA cert, and a certificate and key for the redis server (I used https://github.com/redis/redis/blob/unstable/utils/gen-test-certs.sh which generates all at once)
  2. Run the redis server with the certificate redis-server --tls-port 6379 --port 0 --tls-cert-file ./tests/tls/redis.crt --tls-key-file ./tests/tls/redis.key --tls-ca-cert-file ./tests/tls/ca.crt
  3. Run the ssl example script with the correct certificates
IlyaSkriblovsky commented 1 year ago

Thanks a lot! I will make a release on the weekend.

roeltm commented 1 year ago

@IlyaSkriblovsky When will you be able to release this?

IlyaSkriblovsky commented 1 year ago

@roeltm Done it, sorry for the delay