Win-Git-Bash - Githubissues

Im-Beast / deno_tui

🦕 Deno module for creating Terminal User Interfaces

https://deno.land/x/tui

MIT License

266 stars 18 forks source link

Win-Git-Bash #26

Closed nhrones closed 1 year ago

nhrones commented 1 year ago

The docs recommend WSL for Windows users. I don't use WSL, but Git for Windows, installs GIT-bash, and this works very well for me.
You might want to test this first, and then offer that advice in the docs. Also, it's easy to make GIT-bash the default terminal in VS Code.

Im-Beast commented 1 year ago

I'll check it tommorow

Im-Beast commented 1 year ago

I've tested it on Windows 11 and:

Git Bash works fine, however it renders many characters in a way that looks weird when it comes to the Tui, also dragging movable box around feels a little bit slow.
It seems like performance of cmd, or Windows Terminal has improved and it basically that of WSL

I'll need to check these things on Windows 10 though, because those things might've been improved in just Windows 11

nhrones commented 1 year ago

Thanks for the look. Love TUI!

Im-Beast commented 1 year ago

Sorry, but this issue could still apply, check my previous message:

I'll need to check these things on Windows 10 though, because those things might've been improved in just Windows 11

Documentation still needs to be adjusted either way, as performance on windows 11 seemed on pair with that of WSL

Im-Beast commented 1 year ago

Performance seems to have improved even on latest Windows 10, WSL isn't as neccessary for Tui as it once was. Thanks for this issue!

nhrones commented 1 year ago

I've had issues with WSL, so I cleaned up and use Git-Bash, and never looked back. Also never any of issues that original WSL was causing. Git bash works great as the default in VS Code. I can run all examples from Deno docs and blog posts without 'cmd' incompatibilities.