ImAiiR / QobuzDownloaderX

QBDLX is a program that downloads streams directly from Qobuz
684 stars 118 forks source link

Download failed #10

Closed balleno75 closed 4 years ago

balleno75 commented 4 years ago

Hello, in version 0.9.9.10, any download fails,

https://open.qobuz.com/album/zws6itr39mxqb

image

This error occurs since version 0.9.9.10. So far, I have been able to download without problems.

Please can you check it? Thank you. Greetings.

balleno75 commented 4 years ago

I have discovered the problem,

Apparently now, it depends on the language of the S.O. Windows, since I have tested it on an S.O. with language in English (USA) and has been downloaded without problems.

image

devandikurniarestuandika commented 4 years ago

yes, same problem. should i change my PC language to English? but, i got other problem.

System.Net.WebException: The remote server returned an error: (401) Unauthorized. at System.Net.HttpWebRequest.GetResponse() at QobuzDownloaderX.LoginFrm.loginBG_DoWork(Object sender, DoWorkEventArgs e)

ImAiiR commented 4 years ago

I'm starting to wonder 2 things. 1, are people getting different types of responses from the API for the release date value? 2, is it all the same and I should worry about changing how I'm converting it so the DateTime error stops happening?

I've had someone get the download to work on 0.9.9.9 and the release date was working, which is what makes me wonder if the API is giving different results depending on the person.

yes, same problem. should i change my PC language to English? but, i got other problem.

System.Net.WebException: The remote server returned an error: (401) Unauthorized. at System.Net.HttpWebRequest.GetResponse() at QobuzDownloaderX.LoginFrm.loginBG_DoWork(Object sender, DoWorkEventArgs e)

For this one, is it while logging in? or is it when trying to download? If while logging in that's still being looked in to. For some login is working fine, and for others it isn't, and I haven't been able to find a reason behind it yet.

devandikurniarestuandika commented 4 years ago

when I try to download a track, and it happens not responding

balleno75 commented 4 years ago

The language of my region is Spanish (Spain), and when changing it to English (USA), the download has worked correctly, so it fixes the error.

This problem has been introduced since version 0.9.9.10.

I have seen the program code and the changes applied in version 0.9.9.10 and the error may come, for this conversion,

QobuzDownloaderX/Form1.cs

    // Set DateTime for new date formatting.
    System.DateTime dateTime = new System.DateTime(1970, 1, 1, 0, 0, 0, 0);

    public string DateConvertion(string Input)
    {
        var date = DateTime.ParseExact(Input, "M/d/yyyy hh:mm:ss tt",
                                        CultureInfo.InvariantCulture);

        return date.ToString("yyyy-MM-dd");
    }
balleno75 commented 4 years ago

in Spain the date format is d/M/yyyy and for this reason it generates the error

ImAiiR commented 4 years ago

So it seems Qobuz added the original way they showed release dates back, so the 0.9.9.10 update wasn't even needed. I've reverted the code back to how it was, 0.9.9.9 should work for you until the next update, since there wasn't any other features added in 0.9.9.10.

I'll be trying to get the next update out ASAP so the update box will stop being an annoyance for those stuck on 0.9.9.9.

balleno75 commented 4 years ago

thank you. Greetings

ImAiiR commented 4 years ago

Alright, all should be fixed for the release date bug in version 0.9.9.11. If you run into anything else directly related to the release date, I'll re-open this.

https://github.com/ImAiiR/QobuzDownloaderX/releases/tag/0.9.9.11