ImAiiR / QobuzDownloaderX

QBDLX is a program that downloads streams directly from Qobuz
679 stars 118 forks source link

[Feature Request] Add russian language (ru.json) #178

Closed Kuzmich55 closed 2 days ago

Kuzmich55 commented 6 days ago

Hello, I have translated the application into Russian. Where should I place the ru.json file so that I can easily update and add it to the source code in the future?

ImAiiR commented 6 days ago

Can add the file to this issue, and I'll test it out, see if there's anything that I need to change design wise. Will probably add a way for languages to auto-update when QBDLX is run, but for now, manually adding to the folder.

Kuzmich55 commented 6 days ago

In some places, mainly on buttons and fields of a specific size, I had to shorten the phrases or switch from uppercase to lowercase letters to fit the text. Some fields don't have entries in the resource file, so they cannot be translated. (FAVORITES TEMPLATE; TEMPLATES LIST)

Fields where the phrase in Russian was shortened while maintaining the meaning:

"additionalSettingsButton": "Additional Settings",
"additionalSettingsButton": "Additionally",

"closeAdditionalButton": "Back to Settings",
"closeAdditionalButton": "Back",

"openFolderButton": "Open Folder",
"openFolderButton": "Open",

"qualitySelectButton": "Quality Selector",
"qualitySelectButton": "Quality",

"selectFolderButton": "Select Folder",
"selectFolderButton": "Select",

Fields where the letters were switched from uppercase to lowercase:

"downloadButton": "GET",
"searchAlbumsButton": "RELEASES",
"searchTracksButton": "TRACKS",

The MD5 correction also works (Windows 10) if flac.exe is placed in the same folder as the executable file or if a relative symbolic link is created. This might be worth mentioning in the MD5 correction function description.

ru.json.zip

Kuzmich55 commented 6 days ago

Additionally, the Russian font doesn't look good, especially the difference is noticeable in the screenshot.

Default

ImAiiR commented 6 days ago

In some places, mainly on buttons and fields of a specific size, I had to shorten the phrases or switch from uppercase to lowercase letters to fit the text.

I knew this would most likely be an issue in different languages, glad you were able to shorten things to get them to fit, but I’ll still look into updating the design to be more friendly for longer translations.

Some fields don't have entries in the resource file, so they cannot be translated. (FAVORITES TEMPLATE; TEMPLATES LIST)

If you’d like, send me the translations for these, and I’ll add them, seems I had forgotten them. (Favorites currently goes unused, so may remove that, we will see)

The MD5 correction also works (Windows 10) if flac.exe is placed in the same folder as the executable file or if a relative symbolic link is created. This might be worth mentioning in the MD5 correction function description.

Good to know! I remember having someone test, and even when it was in the same path as QBDLX, it didn’t work, so it seems to be a bit weird depending on the user/setup

Additionally, the Russian font doesn't look good, especially the difference is noticeable in the screenshot.

Will see if I can add a way for the font to be changed in the JSON file, so that the translator can choose a better font if needed. Can’t promise this one yet, but if I can do it, I’ll include it!

Kuzmich55 commented 5 days ago

If you’d like, send me the translations for these, and I’ll add them, seems I had forgotten them. (Favorites currently goes unused, so may remove that, we will see)

Translation of these two lines below.

FAVORITES TEMPLATE = ШАБЛОН ИЗБРАННОГО TEMPLATES LIST = СПИСОК ШАБЛОНОВ

I plan to continue providing support for the app's Russian localization in the future. Keep in touch.

ImAiiR commented 5 days ago

Alright, so I've done a few updates, have your translation working & updated with the translations I had forgotten, along with the ability to use a different font. I've used the font "Segoe UI Symbol", do you think this font looks a bit better? Don't want to push the update with a bad font choice, lol.

languages-2024-11-20

Kuzmich55 commented 4 days ago

Both NIRMALA UI and Segoe UI Symbol look the same in Russian (Cyrillic), likely because they do not have a specific style for Cyrillic characters. They may be using a common or alternative font, which is why they appear identical in Russian. I haven't found a universal solution. I suggest keeping the current version as is until a better or more universal option becomes available.

Segoe UI looks very similar in both Latin and Cyrillic. Maybe it will work?

ImAiiR commented 3 days ago

Segoe UI does look a bit better, at least to me, will use that for now unless a better font is found. Update will be pushed soon and this language will be included, thanks!

ImAiiR commented 2 days ago

Added to 1.0.0.9!