search

ImGuiNET / ImGui.NET

An ImGui wrapper for .NET.
MIT License
1.81k stars 298 forks source link

Use .NET 7 in Build_Windows CI job #408

Closed NoahStolk closed 1 year ago

NoahStolk commented 1 year ago

The code generator was updated to .NET 7 here: https://github.com/ImGuiNET/ImGui.NET/pull/405

zaafar commented 1 year ago

yeah, that should fix it. i am currently looking at following issues.

1: we missed the code that isn't generated via code-generator: https://github.com/ImGuiNET/ImGui.NET/blob/master/src/ImGui.NET/ImGui.Manual.cs

2: if you pass string.empty is fails in master but works in 1.89.5. Following code fixes that.

                            preCallLines.Add($"#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP2_1_OR_GREATER");
                            preCallLines.Add($"if ({textToEncode} != null && !{textToEncode}.IsEmpty)");
                            preCallLines.Add($"#else");
                            preCallLines.Add($"if ({textToEncode} != null)");
                            preCallLines.Add($"#endif");
                            preCallLines.Add("{");
zaafar commented 1 year ago

issue number 3: https://github.com/ImGuiNET/ImGui.NET/actions/runs/5227525012/jobs/9439221901 basically I can't use a, b, c in tags. let me see what I can do about it. releasing this might take a couple of days (i need to talk to imgui & cimgui folks). I don't wanna use 1.89.6 when we are currently not updated to 1.89.6 (https://github.com/ocornut/imgui/blob/master/docs/CHANGELOG.txt#L44)

NoahStolk commented 1 year ago
  1. I'll have a look at these later today.
  2. Apologies for missing that. Are you sure the IsEmpty check fixes it? Both null and string.Empty result in an AccessViolationException, even with IsEmpty. I'm not sure why yet.
  3. I agree we shouldn't release this as 1.89.6. Maybe we could use 1.89.5.1 or something?