search

ImMattDavison / NoMoreDomains

NoMoreDomains is a browser extension tool made to stop you from registering new domains. We're all guilty of registering domains we don't need so use this tool to help stop yourself!
https://chrome.google.com/webstore/detail/no-more-domains/hogoomjmkoljjohkheopfinecmfnckme
GNU General Public License v3.0
68 stars 44 forks source link

Avoid duplicate entries in `whiteList_Memory` #105

Closed tusharsnx closed 1 year ago

tusharsnx commented 1 year ago

This PR implements whiteList_Memory as a Set to avoid storing duplicate entries on the list. If user enters the same url again, the duplicated entry is discarded as the result.

No changes is made on how urls is stored with chrome.storage API. whiteList_Memory is converted to an Array just before it is stored with the API, hence no breaking changes is expected.

ImMattDavison commented 1 year ago

I'll take a look at this as soon as I have a moment to do so @tusharsnn, if you're looking for other issues to work on #78 might be a good fit and I'd appreciate you having a look!

tusharsnx commented 1 year ago

I was working on #78 when I found this issue, so I tried to fix it.

ImMattDavison commented 1 year ago

Ah perfect - no computer just now to run tests and merge but will check tomorrow or Tuesday!

tusharsnx commented 1 year ago

This needs to go before oct 31 😬

ImMattDavison commented 1 year ago

This needs to go before oct 31 😬

I will work as hard as I can to make that happen!

tusharsnx commented 1 year ago

any update required on this?

ImMattDavison commented 1 year ago

any update required on this?

I'll be back at the computer later today