search

ImMattDavison / NoMoreDomains

NoMoreDomains is a browser extension tool made to stop you from registering new domains. We're all guilty of registering domains we don't need so use this tool to help stop yourself!
https://chrome.google.com/webstore/detail/no-more-domains/hogoomjmkoljjohkheopfinecmfnckme
GNU General Public License v3.0
68 stars 44 forks source link

Add individual WhiteList entry deletion #107

Closed tusharsnx closed 1 year ago

tusharsnx commented 1 year ago

Description

This PR will add an individual WhiteList entry deletion feature to the extension's /options page. User will be able to delete specific whitelist domain from the full list of whitelist domains visible on the page.

Closes: #78

tusharsnx commented 1 year ago

Consider merging #105 before this, as the PR branch is based off of the earlier PR.

ImMattDavison commented 1 year ago

Consider merging #105 before this, as the PR branch is based off of the earlier PR.

Definitely! Will test these PRs tonight!

ImMattDavison commented 1 year ago

@tusharsnn after testing this does not actually remove the whitelist entry

tusharsnx commented 1 year ago

what issue did you face ? I tested it and seems to work fine.

Can you give me steps to reproduce the issue that you are facing?

ImMattDavison commented 1 year ago

what issue did you face ? I tested it and seems to work fine.

Can you give me steps to reproduce the issue that you are facing?

Upon clicking the delete button nothing changed and the domain remained part of the whitelist.

tusharsnx commented 1 year ago

I think I understand the issue, the "remove all domains" doesn't work as expected with the new modifications. To solve this, we need to use async/await instead of callbacks. Should I go improve it a bit if you like ? The current implementation will also likely improve as async await is easier to read and maintain and reduces code lines.

ImMattDavison commented 1 year ago

I think I understand the issue, the "remove all domains" doesn't work as expected with the new modifications. To solve this, we need to use async/await instead of callbacks. Should I go improve it a bit if you like ?

The current implementation will also likely improve as async await is easier to read and maintain and reduces code lines.

When I ran tests in the live version with this merged the X buttons didn't work.

This is the issue.

Feel free to make changes as you think will fix it, I look forward to seeing your solution.