Refactor `options.js` - Githubissues

ImMattDavison / NoMoreDomains

NoMoreDomains is a browser extension tool made to stop you from registering new domains. We're all guilty of registering domains we don't need so use this tool to help stop yourself!

https://chrome.google.com/webstore/detail/no-more-domains/hogoomjmkoljjohkheopfinecmfnckme

GNU General Public License v3.0

68 stars 44 forks source link

Refactor `options.js` #118

Closed tusharsnx closed 1 year ago

tusharsnx commented 1 year ago

Updates

In this PR, options.js has been highly refactored to improve maintainability.

Changes this Pull Request makes:

we introduced async/await to reliably modify chrome.storage.local to fix some edges.

How to test this PR:

This PR touches almost all the code in options.js, hence all operations needs to be tested e.g:

adding whitelist entry
removing each entry by its deletion button
removing all whitelist entries together with 'Remove all whitelist'

Checklist:

[x] I have read the Contributing Guidelines
[x] I have read the Code of Conduct
[x] I have followed the editor config
[x] I have made an issue or been assigned to one for this feature/fix (issues)