search

ImMattDavison / NoMoreDomains

NoMoreDomains is a browser extension tool made to stop you from registering new domains. We're all guilty of registering domains we don't need so use this tool to help stop yourself!
https://chrome.google.com/webstore/detail/no-more-domains/hogoomjmkoljjohkheopfinecmfnckme
GNU General Public License v3.0
68 stars 44 forks source link

Support Mozilla Firefox browser #58

Open ImMattDavison opened 1 year ago

ImMattDavison commented 1 year ago

create a conversion of this extension for mozilla firefox

gavinroderick commented 1 year ago

hey, I'd like to pick this up if that's ok?

ImMattDavison commented 1 year ago

hey, I'd like to pick this up if that's ok?

Assigned!

gavinroderick commented 1 year ago

damn that was speedy! 🏎️

ImMattDavison commented 1 year ago

damn that was speedy! 🏎️

🏎️💨

codingfarhan commented 1 year ago

Hi, what's the status? Can I help in any way? I'm open to fixing any issue in the project so please let me know.

gavinroderick commented 1 year ago

Hey @codingfarhan I picked this up and started looking - i think it's probably a bit above what I have capacity to do rn, happy if you want to pick it up and try it!

cc. @immattdavison

ImMattDavison commented 1 year ago

Hey @gavinroderick there is already a PR for this, it just needs rearranging so that MV2 and MV3 versions are separated, I can work on it over the weekend unless you want to?

gavinroderick commented 1 year ago

yeah I looked at the PR, I'll be honest I don't have any experience with extensions and figured this would be a nice place to start! works been super draining this week so i don't think i'll be working on it, sorry!

ImMattDavison commented 1 year ago

yeah I looked at the PR, I'll be honest I don't have any experience with extensions and figured this would be a nice place to start! works been super draining this week so i don't think i'll be working on it, sorry!

That's fair enough, thanks for your help!

codingfarhan commented 1 year ago

Late here, but I would love to pick up on the issue. @immattdavison can I still work on this?

ImMattDavison commented 1 year ago

Late here, but I would love to pick up on the issue. @immattdavison can I still work on this?

For sure - please not FireFox requires MV2 - the best option would be to put all current files into a folder called MV3 and make another version with the same functions in a folder named MV2 of course leave README and other similar files in the root dir

ImMattDavison commented 1 year ago

@codingfarhan #61 may be a good starting point!

codingfarhan commented 1 year ago

@codingfarhan #61 may be a good starting point!

Thanks, I'll get right into it.

ImMattDavison commented 1 year ago

@codingfarhan #61 may be a good starting point!

Thanks, I'll get right into it.

Thanks! Looking forward to your PR!

codingfarhan commented 1 year ago

Facing difficulty implementing MV2 for Firefox, I may not be able to do it. Sorry guys. Please look over it @immattdavison