ImNotStable / QualityEconomy

GNU General Public License v3.0
4 stars 2 forks source link

WithDraw & baltop commands + placeholders. #5

Closed Pointzs closed 8 months ago

Pointzs commented 8 months ago

the withdraw command works perfectly but the item is the problem. I don't want it to be italic for the name and lore but it is even though my messages.config has it set to only be coloured and bold.

The placeholders work perfectly other than the one simple fact that on the %qualityeconomy_balance% placeholder it doesnt show the formatted balance with commas or M B K T QT Q when players have hit those balances. when i hit 1M it shows 1000000 not 1,000,000 or 1M.

On /baltop it still show server total as the unformatted balance. e.g. if server total is 1M it still shows 1e6 rather than 1,000,000.

Pointzs commented 8 months ago

[15:37:31 INFO]: LmaoLoq issued server command: /qe reload [15:37:31 INFO]: [com.zaxxer.hikari.HikariDataSource] QualityEconomyPool - Shutdown initiated... [15:37:31 INFO]: [com.zaxxer.hikari.HikariDataSource] QualityEconomyPool - Shutdown completed. [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 27 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?]at net.minecraft.commands.Commands.sendAsync(Commands.java:380) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 28 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?]at net.minecraft.commands.Commands.sendAsync(Commands.java:374) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 29 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?] at net.minecraft.commands.Commands.sendAsync(Commands.java:380) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 30 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?] at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?]at net.minecraft.commands.Commands.sendAsync(Commands.java:374) ~[?:?] at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 31 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?]at net.minecraft.commands.Commands.sendAsync(Commands.java:380) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 INFO]: [com.zaxxer.hikari.HikariDataSource] QualityEconomyPool - Starting... [15:37:31 INFO]: [com.zaxxer.hikari.pool.HikariPool] QualityEconomyPool - Added connection conn40: url=jdbc:h2:./plugins/QualityEconomy/playerdata user= [15:37:31 INFO]: [com.zaxxer.hikari.HikariDataSource] QualityEconomyPool - Start completed. [15:37:31 INFO]: [QualityEconomy] Successfully initiated storage processes [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 32 java.util.ConcurrentModificationException: null at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?]at net.minecraft.commands.Commands.sendAsync(Commands.java:380) ~[?:?] at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 33 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?] at net.minecraft.commands.Commands.sendAsync(Commands.java:374) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 34 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?] at net.minecraft.commands.Commands.sendAsync(Commands.java:374) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 35 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?]at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?] at net.minecraft.commands.Commands.sendAsync(Commands.java:374) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:31 ERROR]: Caught previously unhandled exception : [15:37:31 ERROR]: Paper Async Task Handler Thread - 36 java.util.ConcurrentModificationException: nullat java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1486) ~[?:?]at java.util.TreeMap$ValueIterator.next(TreeMap.java:1531) ~[?:?] at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:414) ~[?:?] at net.minecraft.commands.Commands.sendAsync(Commands.java:380) ~[?:?]at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?] [15:37:32 INFO]: [BuycraftX] Fetching all due players... [15:37:32 INFO]: [BuycraftX] Fetched due players (0 found).

Pointzs commented 8 months ago

edited config.yml and messages.yml and this happened when i reloaded

Pointzs commented 8 months ago

image

Had to upload image cause github converted the colours to blanks

Pointzs commented 8 months ago

storage-type: h2

decimal-places: 3

banknotes: true

commands: balance: true balancetop: true economy: true pay: true request: true custombalance: false customeconomy: false

custom-currencies: false

backup-interval: 12

balancetop-interval: 300 autosave-accounts-interval: 10

database-information: database: database-name address: localhost port: 0 username: username password: password

advanced-settings: maximum-pool-size: 10 minimum-idle: 10 maximum-lifetime: 1800000 keepalive-time: 0 connection-timeout: 5000

Pointzs commented 8 months ago

Withdraw command has also disabled it self after reloading

Pointzs commented 8 months ago

i am using paper spigot 1.18.2 i am using qualityeconomy 1.4.5 i am using placeholderAPI 2.11.5 i am using Vault 1.7.3

ImNotStable commented 8 months ago

I will look into this once I get home. This will be in about 3 1/2 hours.

Pointzs commented 8 months ago

I will look into this once I get home. This will be in about 3 1/2 hours.

All good. i'm not sure why this keeps breaking the withdraw command only though

Pointzs commented 8 months ago

Also when using the %qualityeconomy_balancetopbalance#% %qualityeconomybalancetop#% placeholders I found an issue. if you add the placeholders for the numbers 1 - 10 but only 1 player has joined the server it will break the plugin i'm using for making the leaderboard for baltop. I am using deluxemenus to make the leaderboard. i have not tried using anything else to see if the same thing happens.

Pointzs commented 8 months ago

If i set the integer value to 1 and remove 2 - 10 then it works perfectly fine

ImNotStable commented 8 months ago

Sorry, but I'm not sure what you mean.

Pointzs commented 8 months ago

Sorry, but I'm not sure what you mean.

When i do %qualityeconomybalancetop#1% the placeholder on the leaderboard works fine because one player has joined the server. But when i do the same thing but for second place it doesnt work and throws a bunch of errors

Pointzs commented 8 months ago

[00:45:18 INFO]: SupremeConCon issued server command: /lb at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?] at com.extendedclip.deluxemenus.menu.MenuItem.getItemStack(MenuItem.java:298) ~[DeluxeMenus-1.14.0-Release.jar:?]at com.extendedclip.deluxemenus.menu.Menu.lambda$openMenu$5(Menu.java:418) ~[DeluxeMenus-1.14.0-Release.jar:?]at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.18.2.jar:git-Paper-388]at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.18.2.jar:git-Paper-388]at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.18.2.jar:git-Paper-388]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]at java.lang.Thread.run(Thread.java:833) ~[?:?]

ImNotStable commented 8 months ago

Oh I assume a second player never joined?

Pointzs commented 8 months ago

since adding the Plugin no a second player hadnt joined but once a second had joined it works fine. but i have seen other plugins that dont require every player to have joined because they return NO DATA if there is no data for that spot

On Sat, 17 Feb 2024 at 1:03 am, ImNotStable @.***> wrote:

Oh I assume a second player never joined?

— Reply to this email directly, view it on GitHub https://github.com/ImNotStable/QualityEconomy/issues/5#issuecomment-1949559007, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DEIB6Q364CRQSIXHKLNBDYT76X3AVCNFSM6AAAAABDMGS6WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGU2TSMBQG4 . You are receiving this because you authored the thread.Message ID: @.***>

ImNotStable commented 8 months ago

I'll add format options for balances, this will take some time as I'm currently working on other aspects of the plugin. I have a commit that has fixed the server total within balancetop and the placeholder balancetop issue.