search

ImSorryButWho / HomeAssistantNotes

Notes on setting up various things in Home Assistant
120 stars 23 forks source link

Aligned some features closer to native Ring behavior #19

Open SEKCobra opened 1 year ago

SEKCobra commented 1 year ago

Made it so you can directly switch between armed modes without having to disarm first. Also extended it so you could change mode while it's still arming, although this is not currently supported by Alarmo (It simply won't process the new arm service call). Also adjusted the countdown event so it uses the next highest countdown feedback, I think this is better than hardcoding the exact amounts, because the final "armed" or "alarm" event will interrupt it anyway, so even though the countdown doesn't quite get to finish if for example set to 10 seconds and using the 15 second countdown, the behavior is still sensible and better than the fallback error beep. Added panic alarm handling, right now this only sets the alarm to pending, but I am already in touch with the Alarmo devs to get that corrected.

Dinth commented 1 month ago

Hi @SEKCobra, have you managed to get those couple of changes merged with the upstream Alarmo?

SEKCobra commented 1 month ago

Hi @SEKCobra, have you managed to get those couple of changes merged with the upstream Alarmo?

Yes, Alarmo is able to go straight into triggered now. Unfortunately my patches have not been integrated to the keypad automations here. Actually it seems I am wrong and the patch is either integrated or was never pull requested.

Dinth commented 1 month ago

Would you mind putting a link to the PR here for visibility? Maybe we can show some support for the changes on their GH

SEKCobra commented 1 month ago

Would you mind putting a link to the PR here for visibility? Maybe we can show some support for the changes on their GH

Sorry, I was getting confused myself about the state of things. Alarmo is updated and supports the behavior fully, probably close to two years. The Home Assistant Template was updated with the changes referenced here, but I believe I made some further improvements that have not yet been integrated, I am discovering right now that I might have forgotten to add a pull request for that. I'll have to check my current version and see if anything needs to be merged.

Dinth commented 1 month ago

Many thanks. Ive got v1 myself and i have been using @ImSorryButWho code for long time now, but there are few odd things in the current behaviour which could be better, so i have high hopes regarding this PR

SEKCobra commented 1 month ago

Ok, got my bearings back, this is the open pull request implementing the fixes I have made. Unfortunately this pull request is still open and therefore not integrated upstream.