search

ImSorryButWho / HomeAssistantNotes

Notes on setting up various things in Home Assistant
120 stars 23 forks source link

emergency buttons #6

Closed jtonk closed 2 years ago

jtonk commented 2 years ago

My thinking for the override was to capture the pin code on the first input, have it stored and called again with force = true when the override is requested. This would mimic the exact functionality as the Ring keypad in a normal Ring security system. However I believe that variables can't be changed upstream in the automation.

A workaround would be to have an additional input in the Blueprint for the override code, but that would expose the code in the frontend. Another option would be to have the user reenter the code within the set timeout, it adds complexity to the arming process and steps away from the functionality in a normal Ring security system .

any suggestions?

ImSorryButWho commented 2 years ago

Hey, thanks very much for this!

So, I definitely like the actions for the emergency buttons. Could you split the force arming off into a separate PR, since that's a little more tricky?

I like the idea of the force arming, but there's a couple of points I want to think about:

I agree that it's a nice function to have; I just want to think about whether this is the best way to do that.

ImSorryButWho commented 2 years ago

Oh, and please get rid of the .DS_Store file.

jtonk commented 2 years ago

Hi,

I'm not quite familiar with pull requests, but I'll try to close this one and submit a separate pull request for the emergency buttons. On the override part, with the helper function it works fine, but you are right, I thought that setting the display mode to password for the helper would prevent the code from being logged (which is not the case and is therefore not a good implementation. Another workaround, but not tested, would be to use the hess-variables custom component, but I'm not sure if those are not being logged. Secondly if the user has no code set, the functionality still works (just tested), I think the logic is that it just sends an empty string for the passcode, and I guess since no password is required alarmo will ignore the data.