Closed cadencep45 closed 5 years ago
ImTheLucKyOne
commented
5 years ago If you are using cmk version 1.5.0 you have to go to the cmk 1.5.0 branch.
https://github.com/ImTheLucKyOne/check_mk_emcunity/tree/cmk-1.5.0-compatibility
This is also stated in the readme btw.
cadencep45
commented
5 years ago Yep, when I went investigating I found our cmk admin had been gung-ho rather than checking version required.
From: Philipp N. [mailto:notifications@github.com] Sent: 14 January 2019 14:58 To: ImTheLucKyOne/check_mk_emcunity check_mk_emcunity@noreply.github.com Cc: Flynn, Bob Bob.Flynn@msx.bala.susq.com; Author author@noreply.github.com Subject: Re: [ImTheLucKyOne/check_mk_emcunity] g_hostname variable not defined ? (#11)
If you are using cmk version 1.5.0 you have to go to the cmk 1.5.0 branch.
https://github.com/ImTheLucKyOne/check_mk_emcunity/tree/cmk-1.5.0-compatibility
This is also stated in the readme btw.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ImTheLucKyOne/check_mk_emcunity/issues/11#issuecomment-454033193, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsVb8NFUrKsbsRiF_f26K7EgXC6sWw6nks5vDJrvgaJpZM4Z16WI.
IMPORTANT: The information contained in this email and/or its attachments is confidential and may only be used by the person to whom it is addressed. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this email and/or any attachment by an unintended recipient is strictly prohibited. Neither this email nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this email and/or any of its attachments are free of viruses. Any views expressed are personal to the author, except where specifically stated to be the views of SIG. SIG accepts no liability of any kind either for any errors arising as a result of electronic transmission or for any loss or damage which may be sustained by any person as a result of this email and/or its attachments being communicated to any person other than the intended recipient.
Susquehanna International Group Limited is a private company limited by shares and registered in Ireland. Registration No.: 445356. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Susquehanna International Securities Limited is a private company limited by shares and registered in Ireland. Registration No.: 337946. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Susquehanna International Securities Limited (UK Branch). Registration No.: FC033877
Liffeyview Property Holdings Limited is a private company limited by shares and registered in Ireland. Registration No.: 534083. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Heights Capital Ireland, LLC is a branch registered in Ireland under registration no. 908306 of Heights Capital Ireland, LLC incorporated in Delaware USA under registration no.: 5762692
SAL Trading, LLC is a branch registered in Ireland under registration no. 906667 of SAL Trading, LLC incorporated in Delaware USA under registration no.: 4984826
Susquehanna International Securities Limited is regulated by the Central Bank of Ireland. Susquehanna International Securities Limited (UK Branch) is regulated by the Financial Conduct Authority for conduct of business rules
If this email relates to investment services and activities as defined in Directive 2014/65/EU of the European Parliament and of the Council of 15 May 2014 on Markets in Financial Instruments (MiFID II), you are receiving the email from Susquehanna International Securities Limited
cadencep45
commented
5 years ago Whats your take on the following
A warning gets automatically generated if fs is > 75% full. My concern is this;
CMK warning that file system is 75% full
Expand fs to get rid of alert
Users see expanded fs from, and add more data. Go to 1.
The concern is if cmk ends up with lots of ignored warnings ( created as designed ), we end up with a warning system which is like the boy who cried wolf !
For ‘hot’ fs which are expected to be > 75% full this throws an issue. I talked to EMC, their response is system operates as designed.
From: Flynn, Bob Sent: 14 January 2019 16:00 To: 'ImTheLucKyOne/check_mk_emcunity' reply@reply.github.com; ImTheLucKyOne/check_mk_emcunity check_mk_emcunity@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [ImTheLucKyOne/check_mk_emcunity] g_hostname variable not defined ? (#11)
Yep, when I went investigating I found our cmk admin had been gung-ho rather than checking version required.
From: Philipp N. [mailto:notifications@github.com] Sent: 14 January 2019 14:58 To: ImTheLucKyOne/check_mk_emcunity check_mk_emcunity@noreply.github.com<mailto:check_mk_emcunity@noreply.github.com> Cc: Flynn, Bob Bob.Flynn@msx.bala.susq.com<mailto:Bob.Flynn@msx.bala.susq.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [ImTheLucKyOne/check_mk_emcunity] g_hostname variable not defined ? (#11)
If you are using cmk version 1.5.0 you have to go to the cmk 1.5.0 branch.
https://github.com/ImTheLucKyOne/check_mk_emcunity/tree/cmk-1.5.0-compatibility
This is also stated in the readme btw.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ImTheLucKyOne/check_mk_emcunity/issues/11#issuecomment-454033193, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsVb8NFUrKsbsRiF_f26K7EgXC6sWw6nks5vDJrvgaJpZM4Z16WI.
IMPORTANT: The information contained in this email and/or its attachments is confidential and may only be used by the person to whom it is addressed. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this email and/or any attachment by an unintended recipient is strictly prohibited. Neither this email nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this email and/or any of its attachments are free of viruses. Any views expressed are personal to the author, except where specifically stated to be the views of SIG. SIG accepts no liability of any kind either for any errors arising as a result of electronic transmission or for any loss or damage which may be sustained by any person as a result of this email and/or its attachments being communicated to any person other than the intended recipient.
Susquehanna International Group Limited is a private company limited by shares and registered in Ireland. Registration No.: 445356. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Susquehanna International Securities Limited is a private company limited by shares and registered in Ireland. Registration No.: 337946. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Susquehanna International Securities Limited (UK Branch). Registration No.: FC033877
Liffeyview Property Holdings Limited is a private company limited by shares and registered in Ireland. Registration No.: 534083. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Heights Capital Ireland, LLC is a branch registered in Ireland under registration no. 908306 of Heights Capital Ireland, LLC incorporated in Delaware USA under registration no.: 5762692
SAL Trading, LLC is a branch registered in Ireland under registration no. 906667 of SAL Trading, LLC incorporated in Delaware USA under registration no.: 4984826
Susquehanna International Securities Limited is regulated by the Central Bank of Ireland. Susquehanna International Securities Limited (UK Branch) is regulated by the Financial Conduct Authority for conduct of business rules
If this email relates to investment services and activities as defined in Directive 2014/65/EU of the European Parliament and of the Council of 15 May 2014 on Markets in Financial Instruments (MiFID II), you are receiving the email from Susquehanna International Securities Limited
ImTheLucKyOne
commented
5 years ago CMK only throws a real warning (and notification) if you configured your warn thresholds for the filesystem check to 75%.
The EMC internal warn threshold is at 75% fixed, that is right. But as it is not practicable for larger filesystems, we ignore the EMC state unless it is in error state. If it is not in an EMC error state, the file system levels are used.
I do not see the problem. Or maybe I did not understand you correctly.
cadencep45
commented
5 years ago The issue is that even for small fs, a warning alert of 75% used is raised, and that this translates to a CMK warning, which then has to be deliberately set into downtime, leading to a Christmas tree of false positives ?
I guess my concern relates to expecting an all OK/green state for a properly functioning system and a 75% alert is a ‘false positive’ warning on a properly functioning system. I guess I am trying to figure out do people simply ‘live with it’ ?
From: Philipp N. [mailto:notifications@github.com] Sent: 09 April 2019 15:53 To: ImTheLucKyOne/check_mk_emcunity check_mk_emcunity@noreply.github.com Cc: Flynn, Bob Bob.Flynn@msx.bala.susq.com; Author author@noreply.github.com Subject: Re: [ImTheLucKyOne/check_mk_emcunity] g_hostname variable not defined ? (#11)
CMK only throws a real warning (and notification) if you configured your warn thresholds for the filesystem check to 75%.
The EMC internal warn threshold is at 75% fixed, that is right. But as it is not practicable for larger filesystems, we ignore the EMC state unless it is in error state. If it is not in an EMC error state, the file system levels are used.
I do not see the problem. Or maybe I did not understand you correctly.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ImTheLucKyOne/check_mk_emcunity/issues/11#issuecomment-481286128, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsVb8A3dnxHLoevOSf4ggasJLy9YEljeks5vfKlPgaJpZM4Z16WI.
IMPORTANT: The information contained in this email and/or its attachments is confidential and may only be used by the person to whom it is addressed. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this email and/or any attachment by an unintended recipient is strictly prohibited. Neither this email nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this email and/or any of its attachments are free of viruses. Any views expressed are personal to the author, except where specifically stated to be the views of SIG. SIG accepts no liability of any kind either for any errors arising as a result of electronic transmission or for any loss or damage which may be sustained by any person as a result of this email and/or its attachments being communicated to any person other than the intended recipient.
Susquehanna International Group Limited is a private company limited by shares and registered in Ireland. Registration No.: 445356. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Susquehanna International Securities Limited is a private company limited by shares and registered in Ireland. Registration No.: 337946. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Susquehanna International Securities Limited (UK Branch). Registration No.: FC033877
Liffeyview Property Holdings Limited is a private company limited by shares and registered in Ireland. Registration No.: 534083. Registered Office Address: International Centre Memorial Road IFSC Dublin 1 Ireland
Heights Capital Ireland, LLC is a branch registered in Ireland under registration no. 908306 of Heights Capital Ireland, LLC incorporated in Delaware USA under registration no.: 5762692
SAL Trading, LLC is a branch registered in Ireland under registration no. 906667 of SAL Trading, LLC incorporated in Delaware USA under registration no.: 4984826
Susquehanna International Securities Limited is regulated by the Central Bank of Ireland. Susquehanna International Securities Limited (UK Branch) is regulated by the Financial Conduct Authority for conduct of business rules
If this email relates to investment services and activities as defined in Directive 2014/65/EU of the European Parliament and of the Council of 15 May 2014 on Markets in Financial Instruments (MiFID II), you are receiving the email from Susquehanna International Securities Limited
ImTheLucKyOne
commented
5 years ago No, currently the EMC warning state ("7" in case of a usage > 75%) is not translated to a CMK warning state("1") if you set the cmk warn parameters to a higher level (defaults are warn 80%, crit 90%).
You can check the plugin code (e.g. emcunity_fs):
the status is calculated by the df_check function with the given parameters/default levels
**status**, infotext, perfdata = df_check_filesystem_single(item, size_mb, avail_mb, 0, None, None, **params**)
the emc health state gets translated to a cmk state
hstate_code = parse_emcstate(hstate)
only if the translated cmk state is > 1 and > the status calculated with usage of the params/levels, the new exit status is the translated cmk state
if hstate_code > 1 and hstate_code > status:
status = hstate_codeSo if we fill the variables with values in case of a system filled to 77% and default levels (80/90%) active, we get this:
status, infotext, perfdata = df_check_filesystem_single(item, size_mb, avail_mb, 0, None, None, params)
status = 0
hstate_code = parse_emcstate(7)
hstate_code = 1
if 1 > 1 and 1 > 0:
status = 1
status = 0So there wont be a false positive.
I see
File "/omd/sites/dev2/local/share/check_mk/checks/emcunity_fs", line 105, in check_emcunity_fs status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params)
when I check for definitions, I see
grep g_hostname * emcunity_fs: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_lun: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_pool: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_vmfs: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params)
g_hostname not defined.
grep size_mb emcunity_fs: size_mb = int(size_B) / 1024.0 / 1024.0 emcunity_fs: allocated_percent = (allocated_mb / size_mb) 100 emcunity_fs: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_lun: size_mb = int(size_B) / 1024.0 / 1024.0 emcunity_lun: avail_mb = size_mb - used_mb emcunity_lun: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_pool: size_mb = int(size_B) / 1024.0 / 1024.0 emcunity_pool: sub_percent = (sub_mb / size_mb) * 100 emcunity_pool: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_vmfs: size_mb = int(size_B) / 1024.0 / 1024.0 emcunity_vmfs: avail_mb = size_mb - used_mb emcunity_vmfs: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params)
size_mb defined
grep avail_mb * emcunity_fs: avail_mb = int(avail_B) / 1024.0 / 1024.0 emcunity_fs: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_lun: avail_mb = size_mb - used_mb emcunity_lun: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_pool: avail_mb = int(avail_B) / 1024.0 / 1024.0 emcunity_pool: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params) emcunity_vmfs: avail_mb = size_mb - used_mb emcunity_vmfs: status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, size_mb, avail_mb, 0, None, None, params)
avail_mb defined
should g_hostname be defined somewhere ?