search

ImageEngine / cortex

Libraries for visual effects software development
Other
528 stars 123 forks source link

USD ShaderAlgo : Fix `treatAs*` and `arnold:*` light parameters #1416

Closed johnhaddon closed 4 months ago

johnhaddon commented 4 months ago

The main motivation for this is to allow Arnold-specific parameters written out of Gaffer to render as expected via the arnold-usd render delegate. In Gaffer we represent these as standard light parameters named as arnold:{name}. But arnold-usd made the unfortunate decision not to represent them as standard light inputs in USD, but to store them as primitive variables instead. With a bit of luck, arnold-usd will align with the USD convention in future and we can ditch this code.

johnhaddon commented 4 months ago

Only thing I noticed is a "# TODO : USE ME!" comment in the tests.

Doh. Thanks for spotting that - I've pushed a new version that actually checks the primvar.

danieldresser-ie commented 4 months ago

LGTM