ImageEngine / cortex

Libraries for visual effects software development
Other
531 stars 124 forks source link

ShaderStateComponent : Handle ToGLTextureConverter exceptions #1418

Closed johnhaddon closed 5 months ago

johnhaddon commented 5 months ago

These were thrown if a GLSL shader had bad values for a texture parameter - the case that motivated this was a custom setup in production that would pass a CompoundData with no channels and an empty data window.

We can't let the exception propagate because addParametersToShaderSetup() is called during drawing and the exception would prevent the rest of the scene drawing and/or lead to a corrupted GL state.

danieldresser-ie commented 5 months ago

LGTM