ImageMarkup / isic-archive

International Skin Imaging Collaboration: Melanoma Project
https://isic-archive.com/
Apache License 2.0
49 stars 10 forks source link

Separate Google Analytics events of Girder web app and external web app #152

Open brianhelba opened 8 years ago

brianhelba commented 8 years ago

The google_analytics plugin doesn't currently distinguish the root URL from the Girder web client and the web_external web client. For example, navigating to '/' and '/girder' will both result in a hit to '/' on Google Analytics. As another example, /girder/collection/... URLs show up as /collection/..., i.e. the /girder prefix is missing.

brianhelba commented 8 years ago

We could consider reverting https://github.com/ImageMarkup/isic-archive/pull/151 , depending on his this is fixed.

msmolens commented 8 years ago

One solution could be to modify backbone.analytics.js to append Backbone.history.root to the fragment, as described here: https://gist.github.com/daveaugustine/1771986#gistcomment-887486

Update: that doesn't work, root '/' regardless of whether in the Girder app or isic-archive app