Fix installed dylib name on macOS

ImageOptim / libimagequant

Palette quantization library that powers pngquant and other PNG optimizers

https://pngquant.org/lib

Other

780 stars 132 forks source link

Fix installed dylib name on macOS #23

Closed felixbuenemann closed 6 years ago

felixbuenemann commented 6 years ago

This fixes an oversight from PR #22, which caused the installed library to be renamed from libimagequant.0.dylib to libimagequant.dylib.0 during make install.

felixbuenemann commented 6 years ago

@kornelski I'm very sorry to cause you ectra work due to my oversight. I prepared the patch a couple days ago when I was working on the homebrew formula and forgot to also test make install today when I submitted it here.

Maybe the 2.12.0 tag is still fresh enough to be overwritten?

felixbuenemann commented 6 years ago

Btw. I have another patch ready that makes make and make install behave more like other Unix tools:

make (all) builds both static and shared libs
make install depends on all and also installs the static lib

I'll submit it as soon as this PR is merged, because it would cause merge conflicts otherwise.

felixbuenemann commented 6 years ago

@kornelski If you're fine with the above mentioned changes I can also push them as part of this PR to avoid the conflicts.

kornelski commented 6 years ago

No problem, I can make another release