search

ImageProcessing-ElectronicPublications / photoquick

Light-weight image viewer with crop,resize,collage, photogrid and filters
GNU General Public License v3.0
4 stars 0 forks source link

Photoquick plugins git? #12

Closed zvezdochiot closed 4 years ago

zvezdochiot commented 4 years ago

:question: Maybe it is worth moving and copy:

src/canvas.h
src/plugin.h
plugins/*

in new git? Example: photoquick-plugins.

ksharindam commented 4 years ago

Dont move these three sample plugins. You can copy them.

On Sat, 27 Jun, 2020, 12:32 PM звездочёт, notifications@github.com wrote:

Maybe it is worth moving and copy:

src/canvas.h src/plugin.h plugins/*

in new git? Example: photoquick-plugins.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ImageProcessing-ElectronicPublications/photoquick/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKWXPR7CGB26R6KUQDUKD3RYWKP7ANCNFSM4OJ4WWKA .

zvezdochiot commented 4 years ago

Hi @ksharindam .

:question: Why not move? Why are they needed in the main project? Need only a link to them in the documentation, or not?

ksharindam commented 4 years ago

Ok, then move them

zvezdochiot commented 4 years ago

Hi @ksharindam .

No no no. You are an author. If you do not like it, then you will cease to support the project. Such decisions can only come from you. I can only advise. Just the logic of creating plugins is incomplete if there is no goal to separate the plugins from the viewer.

ksharindam commented 4 years ago

I was keeping the plugins just as a part of documentation. Plugin documention must be in the main repository. And the documentation needs examples (well commented).

On Sat, 27 Jun, 2020, 12:48 PM звездочёт, notifications@github.com wrote:

Hi @ksharindam https://github.com/ksharindam .

No no no. You are an author. If you do not like it, then you will cease to support the project. Such decisions can only come from you. I can only advise. Just the logic of creating plugins is incomplete if there is no goal to separate the plugins from the viewer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ImageProcessing-ElectronicPublications/photoquick/issues/12#issuecomment-650513198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKWXPWRTIUX6MCKY3XXWPLRYWMNTANCNFSM4OJ4WWKA .

zvezdochiot commented 4 years ago

Hi @ksharindam .

It seems that your idea is incompatible with the idea of separation (although for me a link to the new git in the documentation would be enough). I was just hoping for a centralized git with all the plugins. It is a pity that this is incompatible with your idea.