search

ImageProcessing-ElectronicPublications / photoquick

Light-weight image viewer with crop,resize,collage, photogrid and filters
GNU General Public License v3.0
4 stars 0 forks source link

Effects: Color: Selective Bimodal Threshold (bimod)? #3

Closed zvezdochiot closed 4 years ago

zvezdochiot commented 4 years ago

Hi @ksharindam and all.

:question: Maybe add "Effects: Color: Selective Bimodal Thresold (bimod)"?

See https://github.com/ImageProcessing-ElectronicPublications/gimp-plugin-colors-bimod .

ksharindam commented 4 years ago

It can not be called a threshold. Is not it something like Kuwahara Filter?

zvezdochiot commented 4 years ago

Hi @ksharindam .

:information_source: No. Is this not a Kuwahara filter. If you are talking about example, then these are (5-1)=4 uniform thresholds with color separation (R, G, B) (channels) and averaging brightness (gray). For 2 and disabled options you will get a standard bimodal threshold. And the threshold will be applied to the selection!

:link: See https://github.com/ImageProcessing-ElectronicPublications/gimp-plugin-colors-bimod/blob/4a5d067655b50cff5938c9ce3e93ff9716ea8c40/colors_bimod.py#L20-L44 or https://github.com/ImageProcessing-ElectronicPublications/imthreshold/blob/64bbd4e5ab707b22a9b99d2ccd93ed27f769fcd9/src/lib/threshold.c#L33-L80

:warning: The lack of a frame of choice in "Effects: Color" is bad!

ksharindam commented 4 years ago

I have implemented this in my own repo. But could not merge with this repo. Try to merge.

zvezdochiot commented 4 years ago

:heavy_check_mark: https://github.com/ImageProcessing-ElectronicPublications/photoquick/commit/2977e1ee6dfa408e70def2306fcf2a448e1ce8e3