Gray option in bimodal threshold is confusing

ImageProcessing-ElectronicPublications / photoquick

Light-weight image viewer with crop,resize,collage, photogrid and filters

GNU General Public License v3.0

4 stars 0 forks source link

Gray option in bimodal threshold is confusing #4

Closed ksharindam closed 4 years ago

ksharindam commented 4 years ago

the checkbox text should be changed from gray to something like "Histogram Based". Else user will think that it will output grayscale image if checkbox is checked.

zvezdochiot commented 4 years ago

:question: Gray --> Brightness? BaseLevel? Brightness Correct?

zvezdochiot commented 4 years ago

:question: Maybe there are 2 options ?:

Brightness --> Average between thresholds
Gray --> (R, G, B) -> (A, A, A), A = (R + G + B) / 3

zvezdochiot commented 4 years ago

:question: Maybe you should transfer Bimodal to Effects->Color?

ksharindam commented 4 years ago

when gray is not checked it produces simple multilevel threshold. but when it is checked it produces colors closer to the original using the histogram. This has no relation to brightness so Brightness word would be improper. Also it does not produce average of R,G, and B . so "Average" word is also improper.

ksharindam commented 4 years ago

I will move it under color menu

zvezdochiot commented 4 years ago

Hi @ksharindam .

:information_source: You send commits to this fork. And you always have time to send PR to yourself.

improper

:question: Maybe "Median"?

ksharindam commented 4 years ago

Median is acceptable