search

Imageomics / dashboard-prototype

Prototype data dashboard for Imageomics Data
http://dash.imageomics.org
MIT License
5 stars 2 forks source link

Remove dependence on `Image_filename` for image selector #62

Closed egrace479 closed 4 months ago

egrace479 commented 4 months ago

Displaying sample images required both image_filename and file_url columns. This was an unnecessary complication that is removed in this PR.

Also prints a more specific message when no images are displayed (indicating there are no such entries vs. there are no displayable images for those X entries). This isn't a change in options, just a change in the message itself for greater clarity.

egrace479 commented 4 months ago

I also noticed a bug in the dropdown selector: if you go from specifying subspecies to selecting Any-<species> for the subspecies, then it will not recognize the Any, as it is returned at this stage as a list (['Any']) instead of a string ('Any'), which is the initial return. This is a result of the check for type that was inserted (at line 142 in the updated components/query.py) to address instances of people not removing the "Any" condition when selecting more subspecies (assuming they'd want the specified options). This is something I intend to fix and update in another PR to dev for further testing before updating main and generating a new release.