search

Imaginaerum / magento2-language-fr-fr

Magento 2 - French (France) language pack (fr_fr)
http://imaginaerum.github.io/magento2-language-fr-fr/
MIT License
40 stars 32 forks source link

Contribute missing translation #1086

Open storepeinture opened 7 years ago

storepeinture commented 7 years ago

Hello,

I don't know where else to contribute this, so I open this ticket:

When removing an item from Ajax Cart, Magento shows this message: "Are you sure you would like to remove this item from the shopping cart?" Is it possible to add this to French translation?

Also, it would be great if there would be a way to make easy translations in Magento 2.1.X. It was so easy in Magento 1.9.x ... I know it's not entirely your decision, but maybe you guys can find a way, to make personalized translation available.

Thank you!

DependencyHell commented 7 years ago

Make personalized translation already asked there : #1085

storepeinture commented 7 years ago

Hi DependencyHell,

Thank you for your feedback. So I have tried to personalize the translation.

I have finally found the dictionary, which is located here: ROOT/vendor/imaginaerum/magento2-language-fr-fr/dictionary.csv In this file, I can find all translated phrases that are provided with the imaginaerum Language Pack.

So, I thought, I could just correct something, and I have tried to change the following phrase: "Choir une méthode" to "Choisir une méthode" However the change doesn't show. Even after flushing the cache - no change. Do you (or anybody else) know what else I can do, to fix this phrase and some others?

Thank you!

storepeinture commented 7 years ago

This problem could be related to this magento issue: js-translation.json not populating properly from language package #4067 https://github.com/magento/magento2/issues/4067

storepeinture commented 7 years ago

ekupelian commented on 3 Feb: As a workaround it seems that deleting js-translation.json from pub/static/frontend/Magento/[theme]/[lang_code]/ allows "setup:static-content:deploy [lang_code]" to correctly generate the file. Hope it helps you until Magento patches this issue.

Well, this actually did help ... so at least new translations in the dictionary.csv are taken into account. But corrections still don't display.

DependencyHell commented 7 years ago

Ok, I made a mistake referencing issues, I wanted to do it on the other way.

I will try to get some time this week for this issue, as I think I may need to solve this problem for my project.

Another solution to get your translations working for your modules is creating custom texts into templates files : echo __('Choose a method') could become : echo __('Choose a method M')

and in your i18n/ln_LN.csv files : "Choose a method M","Choisir une méthode"

storepeinture commented 7 years ago

Ok, thank you, I will try this and let you know!