Closed vkt1414 closed 1 year ago
@vkt1414 nice PR summary!
When you reference the corresponding issue, it's usually done by using hash sign followed by issue number in the commit message - this will establish the connection - such as #9.
@vkt1414 sounds good - we should describe those points in the documentation under the respective folder of the repo. Will you update the other workflows or should I do it?
@vkt1414 sounds good - we should describe those points in the documentation under the respective folder of the repo. Will you update the other workflows or should I do it?
I can add/update the readme.md file with in the cwl files folder, to explain how the CWL file is generated, what we chose to keep and what we stripped.
We can do this separately, no need to hold this PR.
Can you make the other changes I asked - updating workflows as the one I modified, and also pushing the images only when the commit is made to the main branch? Let me know if you need help.
We can do this separately, no need to hold this PR.
Can you make the other changes I asked - updating workflows as the one I modified, and also pushing the images only when the commit is made to the main branch? Let me know if you need help.
Sure. I just made changes to github actions files, the same way you edited one yesterday, to rebuild images on main branch only with a pull request.
I also renamed the radiomics to dicom_seg_pyradiomics_sr to describe more closely what we are using the docker image for.. I believe these are all the changes related to dockerfiles.
The last four commits spilled are related to other issues. Will isolate branches going forward.